Skip to content

Commit 709bd13

Browse files
authored
Add link field to Callback (#576)
_**READ BEFORE MERGING:** All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted._ <!-- Describe what has changed in this PR --> **What changed?** Add `links` field to `Callback`. <!-- Tell your future self why have you made these changes --> **Why?** Be able to explicitly associate a callback with links. <!-- Are there any breaking changes on binary or code level? --> **Breaking changes** <!-- If this breaks the Server, please provide the Server PR to merge right after this PR was merged. --> **Server PR**
1 parent 98465b0 commit 709bd13

File tree

3 files changed

+19
-0
lines changed

3 files changed

+19
-0
lines changed

openapi/openapiv2.json

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8952,6 +8952,14 @@
89528952
},
89538953
"internal": {
89548954
"$ref": "#/definitions/CallbackInternal"
8955+
},
8956+
"links": {
8957+
"type": "array",
8958+
"items": {
8959+
"type": "object",
8960+
"$ref": "#/definitions/apicommonv1Link"
8961+
},
8962+
"description": "Links associated with the callback. It can be used to link to underlying resources of the\ncallback."
89558963
}
89568964
},
89578965
"description": "Callback to attach to various events in the system, e.g. workflow run completion."

openapi/openapiv3.yaml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6508,6 +6508,13 @@ components:
65086508
$ref: '#/components/schemas/Callback_Nexus'
65096509
internal:
65106510
$ref: '#/components/schemas/Callback_Internal'
6511+
links:
6512+
type: array
6513+
items:
6514+
$ref: '#/components/schemas/Link'
6515+
description: |-
6516+
Links associated with the callback. It can be used to link to underlying resources of the
6517+
callback.
65116518
description: Callback to attach to various events in the system, e.g. workflow run completion.
65126519
CallbackInfo:
65136520
type: object

temporal/api/common/v1/message.proto

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -211,6 +211,10 @@ message Callback {
211211
Nexus nexus = 2;
212212
Internal internal = 3;
213213
}
214+
215+
// Links associated with the callback. It can be used to link to underlying resources of the
216+
// callback.
217+
repeated Link links = 100;
214218
}
215219

216220
// Link can be associated with history events. It might contain information about an external entity

0 commit comments

Comments
 (0)