Skip to content

Incremental polling for voters, rex balances & delegations#25

Draft
tomtomcrypto wants to merge 42 commits intomasterfrom
incremental
Draft

Incremental polling for voters, rex balances & delegations#25
tomtomcrypto wants to merge 42 commits intomasterfrom
incremental

Conversation

@tomtomcrypto
Copy link

@tomtomcrypto tomtomcrypto commented Jan 28, 2023 •
edited
Loading

Fixes

Updates dependencies (incl. resolving all dependabot alerts)

Description

Implements incremental pooling for voters, rex balances & delegations as well as API improvements

Test scenarios

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages

This was linked to issues Jan 28, 2023
Add delegation support and populate balance.resource_stake #6
Open
Only send staked balances for TLOS #14
Open
Paginate from oldest to newest when doing catch up queries #18
Open
@tomtomcrypto tomtomcrypto marked this pull request as draft January 28, 2023 03:30
@tomtomcrypto tomtomcrypto linked an issue Jan 28, 2023 that may be closed by this pull request
Implement incremental polling via hyperion for voters #21
Open
4 tasks
@tomtomcrypto tomtomcrypto self-assigned this Jan 28, 2023
This was linked to issues Jan 28, 2023
Implement incremental polling via hyperion for rex balances #22
Open
Implement incremental polling via hyperion for delegation #23
Open
@tomtomcrypto tomtomcrypto added the ✨ Enhancement Improvements on existing features label Jan 28, 2023
@tomtomcrypto tomtomcrypto linked an issue Jan 28, 2023 that may be closed by this pull request
Support a limit parameter for holders, voters & delegations routes #4
Open
3 tasks
@karynemayer karynemayer linked an issue Jan 31, 2023 that may be closed by this pull request
Postgres database dropping connection #26
Open
@tomtomcrypto tomtomcrypto linked an issue Feb 3, 2023 that may be closed by this pull request
Add totalVoters & totalHolders in voters & tokens route #27
Open
2 tasks
@tomtomcrypto tomtomcrypto marked this pull request as ready for review February 4, 2023 16:51
poplexity
poplexity reviewed Feb 5, 2023
View reviewed changes
Copy link
Member

@poplexity poplexity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good, much improved 🙏

Left some comments mostly around parameterizing things.

@tomtomcrypto
Copy link
Author

tomtomcrypto commented Feb 5, 2023

This looks really good, much improved 🙏

Left some comments mostly around parameterizing things.

Yeah I started doing it actually and noticed the .env VS config.js too

@tomtomcrypto tomtomcrypto mentioned this pull request Feb 7, 2023
Closed
@karynemayer karynemayer marked this pull request as draft March 2, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment