-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React: Dev server logs full of warnings regarding source maps #804
Comments
I'd strongly prefer using the React wrapper components off-the-shelf instead of having to handle the React <=> Web Component shenanigans myself and/or auto-generating my own wrapper components. Just pointing out that maybe there's an issue with the source maps generation? |
@defaude I don't know if the team behind scale will put any more work into the wrapper library, because you can get it work with the answers of #615 But maybe @acstll or @marvinLaubenstein can give you more details about it |
Hey @defaude thanks for opening this! Thank you @W1ckh3ad also for contributing. The Angular and Vue wrapper packages are indeed deprecated. But the React wrappers are not. The warning says "might" 🙂 The reason for this is the following: Angular and Vue already have great support for web components, but in React support is still experimental (much better now than a year ago, but not quite there yet). @defaude what version of Scale are you using? |
@acstll it should be |
Yup, Let's just hope react will eventually get around to properly work with web components ;) Until then, we'll have to make do with some wrapper for react apps. |
@defaude are you still getting the warnings with |
Closing this assuming it's all good, please re-open or get in touch if not. Thanks again for opening this! |
Hey @acstll ! Sorry for not getting back to you sooner. In fact, I switched to another company and am no longer part of the project team that used the Scale components. I think they came up with their own "handwritten" Scale React component suite but I'm not sure. |
Hey @defaude, no worries. Thanks a lot for the reply, I really appreciate it. All the best in the new company! |
This issue is still there. It can be reproduced in four steps:
The last command will show all the source map errors. Please see my attached "logfile" for details |
hi! please, tell, is it resolved? for me seems not// Here's the screenshot: https://prnt.sc/qzIOEHJFgqPs |
it is appearing for React both JS and TS, when you use create-react-app (it will be now react 18.2.0), which uses react-scripts 5.0.1. If manually change react-scripts version to 2.1.3, this issue got resolved, but a lot of deprecated stuff appears. Scale of newest versions as well: |
Hi @tshimber I've looked into this topic a bit and it seems like the problem is related to create-react-app (discussion: facebook/create-react-app#11767). There is a workaround suggested at the end of that thread to at least remove the warnings from the console: facebook/create-react-app#11767 (comment). Would this be doable for you? |
Hi @felix-ico ! thanks a lot! sorry I was blaming Scale by default and couldn't even think, that it's React unresolved issue:/// really strange from their side/ THANK YOU ones again! |
Using a freshly-squeezed app made by
create-react-app
, I'm getting a ton of warnings regarding source maps likeThe app itself seems to work just fine, but this behavior in the dev server's console is quite annoying :)
The text was updated successfully, but these errors were encountered: