Skip to content

Commit 79e89b9

Browse files
authored
Merge pull request #2868 from AkshataKatwal16/feat-c2c-onboard
Issue feat: Resolve scp timetable and dropout learner issues
2 parents 794300b + e298720 commit 79e89b9

File tree

4 files changed

+7
-5
lines changed

4 files changed

+7
-5
lines changed

mfes/scp-teacher-repo/src/components/CohortLearnerList.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ const CohortLearnerList: React.FC<CohortLearnerListProp> = ({
5656
try {
5757
if (cohortId) {
5858
const page = 0;
59-
const filters = { cohortId: cohortId };
59+
const filters = { cohortId: cohortId , status: [Status.ACTIVE, Status.DROPOUT]};
6060
const response = await getMyCohortMemberListLearner({
6161
limit,
6262
page,

mfes/scp-teacher-repo/src/pages/dashboard.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -937,7 +937,7 @@ const Dashboard: React.FC<DashboardProps> = () => {
937937
after: afterDate,
938938
before: beforeDate,
939939
},
940-
// cohortId: classId,
940+
cohortId: classId,
941941
createdBy: userId,
942942
status: ['live'],
943943
};
@@ -967,7 +967,7 @@ const Dashboard: React.FC<DashboardProps> = () => {
967967
}
968968
};
969969

970-
if (userId && myCohortList) {
970+
if (userId && myCohortList && classId) {
971971
getSessionsData();
972972
}
973973
}, [

mfes/scp-teacher-repo/src/services/MyClassDetailsService.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,9 @@ export const getMyCohortMemberListLearner = async ({
7272
limit,
7373
page,
7474
filters,
75-
}: CohortMemberList & { includeArchived?: boolean }): Promise<any> => {
76-
const statusFilters = [ Status.ACTIVE];
75+
status = [Status.ACTIVE],
76+
}: CohortMemberList & { includeArchived?: boolean; status?: string[] }): Promise<any> => {
77+
const statusFilters = status;
7778

7879
const studentFilters = {
7980
role: Role.STUDENT,

mfes/scp-teacher-repo/src/utils/Interfaces.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,7 @@ export interface CohortMemberList {
107107
tenantStatus?: string[];
108108
name?: string | undefined;
109109
firstName?: string;
110+
status?: string[];
110111
};
111112
includeArchived?: boolean;
112113
}

0 commit comments

Comments
 (0)