From f828aba60254198574e3c7850575f54fc1fa16b1 Mon Sep 17 00:00:00 2001 From: atecle Date: Fri, 17 Jan 2020 10:08:04 -0500 Subject: [PATCH 1/3] Update deployment target for NYTPhotoViewer and NYTPhotoViewerCore to 9.0 --- NYTPhotoViewer.xcodeproj/project.pbxproj | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/NYTPhotoViewer.xcodeproj/project.pbxproj b/NYTPhotoViewer.xcodeproj/project.pbxproj index f5d56032..99300683 100644 --- a/NYTPhotoViewer.xcodeproj/project.pbxproj +++ b/NYTPhotoViewer.xcodeproj/project.pbxproj @@ -700,6 +700,7 @@ developmentRegion = English; hasScannedForEncodings = 0; knownRegions = ( + English, en, Base, ); @@ -1090,7 +1091,7 @@ ); INFOPLIST_FILE = NYTPhotoViewer/Info.plist; INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks"; - IPHONEOS_DEPLOYMENT_TARGET = 8.0; + IPHONEOS_DEPLOYMENT_TARGET = 9.0; LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks"; PRODUCT_BUNDLE_IDENTIFIER = com.NYTimes.NYTPhotoViewer; PRODUCT_NAME = "$(TARGET_NAME)"; @@ -1109,7 +1110,7 @@ GCC_PREPROCESSOR_DEFINITIONS = "ANIMATED_GIF_SUPPORT=1"; INFOPLIST_FILE = NYTPhotoViewer/Info.plist; INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks"; - IPHONEOS_DEPLOYMENT_TARGET = 8.0; + IPHONEOS_DEPLOYMENT_TARGET = 9.0; LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks"; PRODUCT_BUNDLE_IDENTIFIER = com.NYTimes.NYTPhotoViewer; PRODUCT_NAME = "$(TARGET_NAME)"; @@ -1169,7 +1170,7 @@ DYLIB_INSTALL_NAME_BASE = "@rpath"; INFOPLIST_FILE = NYTPhotoViewer/Info.plist; INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks"; - IPHONEOS_DEPLOYMENT_TARGET = 8.0; + IPHONEOS_DEPLOYMENT_TARGET = 9.0; LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks"; PRODUCT_BUNDLE_IDENTIFIER = com.NYTimes.NYTPhotoViewerCore; PRODUCT_NAME = "$(TARGET_NAME)"; @@ -1187,7 +1188,7 @@ DYLIB_INSTALL_NAME_BASE = "@rpath"; INFOPLIST_FILE = NYTPhotoViewer/Info.plist; INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks"; - IPHONEOS_DEPLOYMENT_TARGET = 8.0; + IPHONEOS_DEPLOYMENT_TARGET = 9.0; LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks"; PRODUCT_BUNDLE_IDENTIFIER = com.NYTimes.NYTPhotoViewerCore; PRODUCT_NAME = "$(TARGET_NAME)"; From 8e870859f2fcb2521dbc1ec9ad8659bfdeb97067 Mon Sep 17 00:00:00 2001 From: atecle Date: Fri, 17 Jan 2020 10:09:28 -0500 Subject: [PATCH 2/3] Remove UIPopoverVC which has been deprecated in 9.0 --- NYTPhotoViewer/NYTPhotosViewController.m | 1 - 1 file changed, 1 deletion(-) diff --git a/NYTPhotoViewer/NYTPhotosViewController.m b/NYTPhotoViewer/NYTPhotosViewController.m index e089d081..5a2dd40f 100644 --- a/NYTPhotoViewer/NYTPhotosViewController.m +++ b/NYTPhotoViewer/NYTPhotosViewController.m @@ -37,7 +37,6 @@ - (instancetype)initWithCoder:(NSCoder *)aDecoder NS_DESIGNATED_INITIALIZER; @property (nonatomic) UIPageViewController *pageViewController; @property (nonatomic) NYTPhotoTransitionController *transitionController; -@property (nonatomic) UIPopoverController *activityPopoverController; @property (nonatomic) UIPanGestureRecognizer *panGestureRecognizer; @property (nonatomic) UITapGestureRecognizer *singleTapGestureRecognizer; From 717f3cc7cd10c738b310a4192419c343451ba384 Mon Sep 17 00:00:00 2001 From: atecle Date: Fri, 17 Jan 2020 10:11:44 -0500 Subject: [PATCH 3/3] Update changelog and README --- CHANGELOG.md | 3 +++ README.md | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5983f7ec..80bcc2c0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,9 @@ Changes for users of the library currently on `develop`: +- Update deployment target to 9.0 from 8.0 +- Remove property `UIPopoverController *activityPopoverController` from `NYTPhotosViewController` + ## [3.0.1](https://github.com/nytimes/NYTPhotoViewer/releases/tag/3.0.1) Changes for users of the library in 3.0.1: diff --git a/README.md b/README.md index dcf4727e..ae4cb94d 100644 --- a/README.md +++ b/README.md @@ -47,7 +47,7 @@ pod 'NYTPhotoViewer' ## Requirements -This library requires a deployment target of iOS 8.0 or greater. +This library requires a deployment target of iOS 9.0 or greater. ## Changelog