Skip to content

Commit b792c03

Browse files
committed
Releasing 1.1.3
2 parents 4308998 + 9c8ac16 commit b792c03

File tree

4 files changed

+25
-16
lines changed

4 files changed

+25
-16
lines changed

js/utils.js

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,3 +69,10 @@ WebAppUtils.validateFields = function(path) {
6969

7070
return rc;
7171
};
72+
73+
WebAppUtils.encodeHtmlEntities = function(s) {
74+
var rc = s.replace(/[\u00A0-\u9999<>\&]/g, function(i) {
75+
return '&#'+i.charCodeAt(0)+';';
76+
});
77+
return rc;
78+
};

js/webapp.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ class WebAppModal {
227227
constructor(id) {
228228
this.id = id;
229229
jQuery('#'+id).remove();
230-
jQuery('<div id="'+this.id+'" class="modal" tabindex="-1"><div class="modal-dialog"><div class="modal-content"><div class="modal-header"><h5 class="modal-title"></h5><button type="button" class="close" data-dismiss="modal" aria-label="Close"><span aria-hidden="true">&times;</span></button></div><div class="modal-body"></div><div class="modal-footer"><button type="button" class="btn btn-secondary close-button" data-dismiss="modal">'+webApp.i18n('close')+'</button></div></div></div></div>').appendTo('body');
230+
jQuery('<div id="'+this.id+'" class="modal fade" tabindex="-1"><div class="modal-dialog"><div class="modal-content"><div class="modal-header"><h5 class="modal-title"></h5><button type="button" class="close" data-dismiss="modal" aria-label="Close"><span aria-hidden="true">&times;</span></button></div><div class="modal-body"></div><div class="modal-footer"><button type="button" class="btn btn-secondary close-button" data-dismiss="modal">'+webApp.i18n('close')+'</button></div></div></div></div>').appendTo('body');
231231
this.dom = jQuery('#'+id);
232232
}
233233

src/WebApp/Page.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -277,5 +277,9 @@ public function getJavascript() {
277277
protected function dao($name) {
278278
return $this->app->dao($name);
279279
}
280+
281+
protected function svc($name) {
282+
return $this->app->svc($name);
283+
}
280284
}
281285

src/WebApp/Renderer.php

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -171,14 +171,19 @@ public function setAria($key, $value) {
171171
}
172172

173173
protected function renderStartTag($tagName, $closeTag = FALSE) {
174-
$rc = '<'.$tagName;
174+
$attributes = $this->computeFinalAttributes();
175+
return \TgUtils\Html::renderStartTag($tagName, $attributes, $closeTag);
176+
}
177+
178+
public function computeFinalAttributes() {
179+
$rc = array();
175180

176-
$rc .= ' id="'.htmlspecialchars($this->component->getId()).'"';
181+
$rc['id'] = $this->component->getId();
177182

178-
// Render classes and styles first
183+
// classes
179184
$classes = $this->getAttribute('class', TRUE);
180185
if (($classes != NULL) && (count($classes) > 0)) {
181-
$rc .= ' class="'.htmlspecialchars(trim(implode(' ', $classes))).'"';
186+
$rc['class'] = $classes;
182187
}
183188

184189
$styles = $this->getStyles(TRUE);
@@ -187,26 +192,19 @@ protected function renderStartTag($tagName, $closeTag = FALSE) {
187192
foreach ($styles AS $name => $value) {
188193
$style .= ' '.$name.':'.$value.';';
189194
}
190-
$rc .= ' style="'.htmlspecialchars(trim($style)).'"';
195+
$rc['style'] = trim($style);
191196
}
192197

193198
$attributes = $this->getAttributes(TRUE);
194-
unset($attributes['class']);
199+
unset($attributes['class'], $attributes['style'], $attributes['id']);
195200
foreach ($attributes AS $name => $value) {
196-
if (is_array($value)) $value = implode(' ', $value);
197-
if (is_numeric($value) || is_string($value)) {
198-
$rc .= ' '.$name.'="'.htmlspecialchars($value).'"';
199-
}
201+
$rc[$name] = $value;
200202
}
201-
202-
if ($closeTag) $rc .= '/';
203-
$rc .= '>';
204203
return $rc;
205204
}
206205

207206
protected function renderEndTag($tagName) {
208-
$rc = '</'.$tagName.'>';
209-
return $rc;
207+
return \TgUtils\Html::renderEndTag($tagName);
210208
}
211209

212210
public function getParentFor($componentName) {

0 commit comments

Comments
 (0)