modified file names and functions

Author: umang-clairvoyant

src/app/services/query_builder/__init__.py

@@ -1,2 +1,2 @@
-from .dialact import RedshiftDialact
+from .dialect import RedshiftDialect, RedshiftQuery
 from .query_builder import QueryBuilder

src/app/services/query_builder/dialact.py src/app/services/query_builder/dialect.py

@@ -45,19 +45,20 @@ def left_join(self, item: Table) -> "JoinQuery":
 
 
 @dataclass()
-class RedshiftDialact:
+class RedshiftDialect:
     target_table_conf: List[Dict]
-    joins_and_filers_conf: Dict[str, Dict]
+    joins_and_filters_conf: Dict[str, Dict]
 
-    def build(self) -> None:
+    def get_sql(self) -> None:
         """Method to trrigger Redshift query builder
         """
         logger.info('building Redshift query from the mappings file')
 
         _query = RedshiftQuery()
-        for _index in self.joins_and_filers_conf:
 
-            _map = self.joins_and_filers_conf[_index]
+        for _index in self.joins_and_filters_conf:
+
+            _map = self.joins_and_filters_conf[_index]
 
             if int(_index) == 0:
                 schema1, schema2 = Schema(_map['driving_table'].split(
@@ -68,7 +69,7 @@ def build(self) -> None:
                     Table(_map['reference_table'].split('.')[1],
                           schema=schema2, alias=_map['reference_table_alias'])
 
-                _query = _query.from_(table1).inner_join(  # type: ignore
+                _query = _query.from_(table1).inner_join(
                     table2).on(_map['join_condition'])
             else:
                 schema2 = Schema(_map['reference_table'].split(

src/app/services/query_builder/query_builder.py

@@ -6,7 +6,7 @@
 
 from app.etl_exceptions import AutoETLException
 from app.services.config_parser import ConfigParser, MetadataParser
-from app.services.query_builder import RedshiftDialact
+from app.services.query_builder import RedshiftDialect
 from app.utils import excel_to_json, validate_joins_mapping
 
 logger = logging.getLogger(__name__)
@@ -49,10 +49,9 @@ def run(self) -> None:
             meta_xls, 'joins_and_filters', 'index')
 
         validate_joins_mapping(joins_and_filters)
-
         match _config['target']:
             case 'redshift':
-                RedshiftDialact(target_table_json, joins_and_filters).build()
+                RedshiftDialect(target_table_json, joins_and_filters).get_sql()
 
             case _:
                 logger.error(

src/app/utils.py

@@ -1,7 +1,7 @@
 import json
 import logging
 import os
-from typing import Dict, List
+from typing import Dict
 
 import pandas as pd
 from pydantic import Json
@@ -49,7 +49,7 @@ def validate_joins_mapping(joins_and_filters_conf: Dict[str, Dict]) -> None:
     logger.info('validating and processing joins mapping conf')
     num_joins = len(joins_and_filters_conf)
     logger.info(
-        'found {%d} number of mappings in the configurations', num_joins)
+        'found %d mappings in the configurations', num_joins)
     for _index in joins_and_filters_conf:
         _map = joins_and_filters_conf[_index]
         if _index == 0: