Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating my own I_TestResultLogger #188

Open
doerk77 opened this issue Jun 13, 2022 · 1 comment
Open

Creating my own I_TestResultLogger #188

doerk77 opened this issue Jun 13, 2022 · 1 comment

Comments

@doerk77
Copy link

doerk77 commented Jun 13, 2022

In v1.2.1.0 injection of a custom I_TestResultLogger is pretty much impossible.
I tried to implement my own XML publisher that allows customizing the file name, but I came across a few issues:

  • Extending FB_xUnitXmlPublisher doesn't help since the reference to the file path is in the private method DeleteOpenWriteClose which I cannot overwrite.
    • I could rewrite LogTestSuiteResults to call my own method, but it would be better to have the file path in a separate variable instead of referencing the parameter in the method. This variable should be pointing to the corresponding parameter "xUnitFilePath" as default.
    • Moreover, it would be better to make DeleteOpenWriteClose a protected method and not INTERNAL.
  • Method LogTestSuiteResults is calling AdsMessageQueue.WriteLog() which is an internal method and thereby cannot be accessed from my own implementation. Why isn't this a public method? It's just adding another log entry.
@iadonkey
Copy link

There is a library parameter to set the file name that FB_xUnitXmlPublisher uses

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants