4.5.0 (#183)

* Fix lint issues

* Create v4.5.0 docs

* Remove exceptions and fix version

* Bump version

Author: tclindner

docs/rules/dependencies/no-dup-fields.md

@@ -15,18 +15,6 @@ Enabling this rule will result in an error being generated if package.json has d
 }
 ```
 
-With exceptions
-
-```json
-{
-  "rules": {
-    "no-dup-fields": ["error", {
-      "exceptions": ["myModule"]
-    }]
-  }
-}
-```
-
 ## Rule Details
 
 ### *Incorrect* examples
@@ -60,4 +48,4 @@ With exceptions
 
 ## History
 
-* Introduced in version 4.3.0
+* Introduced in version 4.5.0

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "npm-package-json-lint",
-  "version": "4.4.0",
+  "version": "4.5.0",
   "description": "Configurable linter for package.json files.",
   "keywords": [
     "lint",

package.json

@@ -4,14 +4,14 @@ const LintIssue = require('./../LintIssue');
 
 const lintId = 'no-duplicate-fields';
 const nodeName = '';
-const ruleType = 'optionalObject';
+const ruleType = 'standard';
 
 const lint = (packageJsonData, severity) => {
   /**
    * If we send package json straight to npm-package-json-lint, fallback to empty string.
    * Because we already lose information about duplicate properties.
    */
-  const source = packageJsonData[Parser.sourceSymbol] || ''; // eslint-disable-line
+  const source = packageJsonData[Parser.sourceSymbol] || '';
   const dupProps = findDuplicatePropNames(source);
 
   if (dupProps.length) {

src/rules/no-dup-fields.js

@@ -1,3 +1,5 @@
+const parser = require('jsonc-parser');
+
 /**
  * Determines whether or not the node exists in the package.json file
  * @param  {object} packageJsonData Valid JSON
@@ -14,7 +16,6 @@ const exists = (packageJsonData, nodeName) => {
  * @return {string[]}                  List of duplicate property names.
  */
 const findDuplicatePropNames = packageJsonSource => {
-  const parser = require("jsonc-parser"); // eslint-disable-line
   const tree = parser.parseTree(packageJsonSource);
 
   if (!tree) {

src/validators/property.js

@@ -5,15 +5,16 @@ const {lint, ruleType} = ruleModule;
 
 const parsePackageJson = source => {
   const json = JSON.parse(source);
-  json[Parser.sourceSymbol] = source; // eslint-disable-line
+
+  json[Parser.sourceSymbol] = source;
 
   return json;
 };
 
 describe('no-dup-fields Unit Tests', () => {
   describe('a rule type value should be exported', () => {
-    test('it should equal "optionalObject"', () => {
-      expect(ruleType).toStrictEqual('optionalObject');
+    test('it should equal "standard"', () => {
+      expect(ruleType).toStrictEqual('standard');
     });
   });
 
@@ -23,7 +24,7 @@ describe('no-dup-fields Unit Tests', () => {
         "name": "package1",
         "name": "package2"
       }`);
-      const response = lint(packageJsonData, 'error', {exceptions: ['grunt-npm-package-json-lint']});
+      const response = lint(packageJsonData, 'error');
 
       expect(response.lintId).toStrictEqual('no-duplicate-fields');
       expect(response.severity).toStrictEqual('error');
@@ -41,7 +42,7 @@ describe('no-dup-fields Unit Tests', () => {
           "eslint": "6.7.2"
         }
       }`);
-      const response = lint(packageJsonData, 'error', {exceptions: ['grunt-npm-package-json-lint']});
+      const response = lint(packageJsonData, 'error');
 
       expect(response.lintId).toStrictEqual('no-duplicate-fields');
       expect(response.severity).toStrictEqual('error');

test/unit/rules/no-dup-fields.test.js

@@ -0,0 +1,52 @@
+---
+id: version-4.5.0-no-dup-fields
+title: no-dup-fields
+original_id: no-dup-fields
+---
+
+Enabling this rule will result in an error being generated if package.json has duplicate fields in block section.
+
+## Example .npmpackagejsonlintrc configuration
+
+```json
+{
+  "rules": {
+    "no-dup-fields": "error"
+  }
+}
+```
+
+## Rule Details
+
+### *Incorrect* examples
+
+```json
+{
+  "name": "packageName",
+  "name": "packageName"
+}
+```
+
+
+### *Correct* examples
+
+
+```json
+{
+  "name": "packageName"
+}
+```
+
+## Shorthand for disabling the rule in .npmpackagejsonlintrc configuration
+
+```json
+{
+  "rules": {
+    "no-dup-fields": "off"
+  }
+}
+```
+
+## History
+
+* Introduced in version 4.5.0

website/versioned_docs/version-4.5.0/rules/dependencies/no-dup-fields.md

@@ -1,4 +1,5 @@
 [
+  "4.5.0",
   "4.4.0",
   "4.3.0",
   "4.2.0",