Skip to content

Commit 1b0a91f

Browse files
authored
#53 - Fix for new array rule, prefer-property-order, not loading properly (#55)
1 parent f37e271 commit 1b0a91f

File tree

4 files changed

+31
-3
lines changed

4 files changed

+31
-3
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,11 @@ This project adheres to [Semantic Versioning](http://semver.org/).
1111

1212
### Removed
1313

14+
15+
## [2.8.2] - 2017-08-23
16+
### Fixed
17+
- Rule loader so it recognized [prefer-property-order](https://github.com/tclindner/npm-package-json-lint/wiki/prefer-property-order) as an array type rule.
18+
1419
## [2.8.1] - 2017-08-21
1520
### Changed/Fixed
1621
- Updated rule: [prefer-property-order](https://github.com/tclindner/npm-package-json-lint/wiki/prefer-property-order) based on discussion with @moshest in [issue #50](https://github.com/tclindner/npm-package-json-lint/issues/50) and @evilebottnawi in [issue #53](https://github.com/tclindner/npm-package-json-lint/issues/53).

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "npm-package-json-lint",
3-
"version": "2.8.1",
3+
"version": "2.8.2",
44
"description": "CLI app for linting package.json files.",
55
"keywords": [
66
"lint",

src/NpmPackageJsonLint.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,12 @@ class NpmPackageJsonLint {
1717
constructor(packageJsonData, config, options) {
1818
this.packageJsonData = packageJsonData;
1919
this.ignoreWarnings = options.ignoreWarnings;
20-
this.arrayRuleTypes = ['valid-values', 'no-restricted-dependencies', 'no-restricted-pre-release-dependencies'];
20+
this.arrayRuleTypes = [
21+
'valid-values',
22+
'no-restricted-dependencies',
23+
'no-restricted-pre-release-dependencies',
24+
'property-order'
25+
];
2126
this.errors = [];
2227
this.warnings = [];
2328

tests/fixtures/valid/.npmpackagejsonlintrc.json

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,24 @@
1919
"Thomas Lindner"
2020
]],
2121
"name-format": "error",
22-
"version-format": "error"
22+
"version-format": "error",
23+
"prefer-property-order": ["error", [
24+
"name",
25+
"version",
26+
"description",
27+
"keywords",
28+
"homepage",
29+
"bugs",
30+
"author",
31+
"repository",
32+
"bin",
33+
"files",
34+
"main",
35+
"scripts",
36+
"dependencies",
37+
"devDependencies",
38+
"engines",
39+
"license"
40+
]]
2341
}
2442
}

0 commit comments

Comments
 (0)