Add eslint remove jshint (#7)

* Add eslint support and remove joshing

* Resolve eslint issues

* Add prefer-const rule

Author: tclindner

.eslintrc.json

@@ -0,0 +1,214 @@
+{
+  "parserOptions": {
+    "ecmaVersion": 6,
+    "sourceType": "module"
+  },
+  "env": {
+    "node": true,
+    "es6": true,
+    "mocha": true,
+    "jquery": true
+  },
+  "rules": {
+    "comma-dangle": ["error", "never"],
+    "no-cond-assign": ["error", "always"],
+    "no-constant-condition": "error",
+    "no-dupe-args": "error",
+    "no-dupe-keys": "error",
+    "no-duplicate-case": "error",
+    "no-empty": "error",
+    "no-empty-character-class": "error",
+    "no-ex-assign": "error",
+    "no-extra-boolean-cast": "error",
+    "no-extra-parens": ["error", "all", { "conditionalAssign": false }],
+    "no-extra-semi": "error",
+    "no-func-assign": "error",
+    "no-invalid-regexp": ["error", {
+    "allowConstructorFlags": ["u", "y"]}],
+    "no-irregular-whitespace": "error",
+    "no-negated-in-lhs": "error",
+    "no-obj-calls": "error",
+    "no-regex-spaces": "error",
+    "no-sparse-arrays": "error",
+    "no-unreachable": "error",
+    "use-isnan": "error",
+    "valid-jsdoc": "error",
+    "no-unexpected-multiline": "error",
+    "valid-typeof": "error",
+    "accessor-pairs": "error",
+    "array-callback-return": "error",
+    "block-scoped-var": "error",
+    "complexity": "error",
+    "consistent-return": "error",
+    "curly": "error",
+    "default-case": "error",
+    "dot-location": ["error", "property"],
+    "dot-notation": "error",
+    "eqeqeq": "error",
+    "no-caller": "error",
+    "no-case-declarations": "error",
+    "no-div-regex": "error",
+    "no-empty-function": "error",
+    "no-empty-pattern": "error",
+    "no-eq-null": "error",
+    "no-eval": "error",
+    "no-extend-native": "error",
+    "no-extra-bind": "error",
+    "no-extra-label": "error",
+    "no-fallthrough": "error",
+    "no-floating-decimal": "error",
+    "no-implicit-coercion": "error",
+    "no-implicit-globals": "error",
+    "no-implied-eval": "error",
+    "no-invalid-this": "error",
+    "no-iterator": "error",
+    "no-labels": "error",
+    "no-lone-blocks": "error",
+    "no-loop-func": "error",
+    "no-magic-numbers": "error",
+    "no-multi-spaces": "error",
+    "no-multi-str": "error",
+    "no-native-reassign": "error",
+    "no-new": "error",
+    "no-new-func": "error",
+    "no-new-wrappers": "error",
+    "no-octal": "error",
+    "no-octal-escape": "error",
+    "no-param-reassign": "error",
+    "no-proto": "error",
+    "no-redeclare": "error",
+    "no-return-assign": "error",
+    "no-script-url": "error",
+    "no-self-assign": "error",
+    "no-self-compare": "error",
+    "no-sequences": "error",
+    "no-throw-literal": "error",
+    "no-unmodified-loop-condition": "error",
+    "no-unused-expressions": "error",
+    "no-unused-labels": "error",
+    "no-useless-call": "error",
+    "no-useless-concat": "error",
+    "no-useless-escape": "error",
+    "no-void": "error",
+    "no-warning-comments": "error",
+    "no-with": "error",
+    "radix": "error",
+    "vars-on-top": "error",
+    "wrap-iife": ["error", "outside"],
+    "yoda": "error",
+    "no-catch-shadow": "error",
+    "no-delete-var": "error",
+    "no-label-var": "error",
+    "no-shadow": "error",
+    "no-shadow-restricted-names": "error",
+    "no-undef": "error",
+    "no-undefined": "error",
+    "no-use-before-define": "error",
+    "callback-return": "error",
+    "handle-callback-err": "error",
+    "no-mixed-requires": "error",
+    "no-new-require": "error",
+    "no-path-concat": "error",
+    "no-process-env": "error",
+    "no-process-exit": "error",
+    "array-bracket-spacing": ["error", "never"],
+    "brace-style": "error",
+    "camelcase": "error",
+    "comma-spacing": ["error", { "before": false, "after": true }],
+    "comma-style": ["error", "last"],
+    "computed-property-spacing": ["error", "never"],
+    "eol-last": "error",
+    "func-style": ["error", "expression"],
+    "id-length": ["error", {"min": 2, "max": 20}],
+    "indent": ["error", 2],
+
+    "key-spacing": ["error", {"beforeColon": false, "afterColon": true}],
+
+    "keyword-spacing": "error",
+    "linebreak-style": ["error", "unix"],
+    "max-depth": ["error", 4],
+    "max-nested-callbacks": ["error", 3],
+    "max-params": ["error", 4],
+    "max-statements": ["error", 12],
+    "max-statements-per-line": ["error", { "max": 1 }],
+    "new-cap": "error",
+    "new-parens": "error",
+    "newline-after-var": "error",
+    "newline-before-return": "error",
+    "newline-per-chained-call": ["error", {"ignoreChainWithDepth": 3}],
+    "no-array-constructor": "error",
+    "no-bitwise": "error",
+    "no-continue": "error",
+    "no-inline-comments": "error",
+    "no-lonely-if": "error",
+    "no-mixed-spaces-and-tabs": "error",
+    "no-multiple-empty-lines": ["error", {"max": 2}],
+    "no-negated-condition": "error",
+    "no-nested-ternary": "error",
+    "no-new-object": "error",
+    "no-plusplus": "error",
+    "no-trailing-spaces": "error",
+    "no-unneeded-ternary": "error",
+    "no-whitespace-before-property": "error",
+    "object-curly-spacing": ["error", "never"],
+    "one-var": ["error", "never"],
+    "operator-assignment": ["error", "always"],
+    "padded-blocks": ["error", { "classes": "always" }],
+    "quote-props": ["error", "consistent"],
+    "quotes": ["error", "double"],
+    "require-jsdoc": ["error", {
+      "require": {
+        "FunctionDeclaration": true,
+        "MethodDefinition": true,
+        "ClassDeclaration": false
+      }
+    }],
+    "semi": ["error", "always"],
+    "semi-spacing": ["error", {"before": false, "after": false}],
+    "sort-imports": "error",
+    "sort-vars": "error",
+    "space-before-blocks": ["error", {
+      "functions": "always",
+      "keywords": "always",
+      "classes": "always"
+    }],
+    "space-before-function-paren": ["error", "never"],
+    "space-in-parens": ["error", "never"],
+    "space-unary-ops": [2, {
+      "words": true,
+      "nonwords": false
+    }],
+    "spaced-comment": ["error", "always"],
+    "wrap-regex": "error",
+    "lines-around-comment": ["error", {
+      "allowArrayStart": false,
+      "allowArrayEnd": false,
+      "allowBlockStart": true,
+      "allowBlockEnd": false,
+      "allowObjectStart": false,
+      "allowObjectEnd": false,
+      "afterBlockComment": false,
+      "afterLineComment": false,
+      "beforeBlockComment": true,
+      "beforeLineComment": true
+    }],
+    "arrow-body-style": ["error", "always"],
+    "arrow-parens": ["error", "always"],
+    "arrow-spacing": ["error", { "before": true, "after": true }],
+    "constructor-super": "error",
+    "no-class-assign": "error",
+    "no-confusing-arrow": ["error", {"allowParens": true}],
+    "no-const-assign": "error",
+    "no-dupe-class-members": "error",
+    "no-duplicate-imports": "error",
+    "no-new-symbol": "error",
+    "no-this-before-super": "error",
+    "no-useless-constructor": "error",
+    "no-var": "error",
+    "object-shorthand": "error",
+    "prefer-const": "error",
+    "prefer-rest-params": "error",
+    "prefer-template": "error",
+    "template-curly-spacing": "error"
+  }
+}

.jshintrc

@@ -31,9 +31,9 @@ Run `node src/cli.js`
 
 ### JS
 
-npm package json lint utilizes both JSHint and JSCS to enforce JavaScript standards. Please see the `.jshintrc` file for JSHint config and `.jscsrc` for JSCS config.
+npm package json lint utilizes both ESLint and JSCS to enforce JavaScript standards. Please see the `.eslintrc.json` file for ESLint config and `.jscsrc` for JSCS config.
 
-* [grunt-contrib-jshint](https://github.com/gruntjs/grunt-contrib-jshint)
+* [grunt-eslint](https://github.com/sindresorhus/grunt-eslint)
 * [grunt-jscs](https://github.com/jscs-dev/grunt-jscs)
 
 #### JSON

CONTRIBUTING.md

@@ -3,15 +3,16 @@ module.exports = function(grunt) {
   grunt.initConfig({
     pkg: grunt.file.readJSON("package.json")
   });
+
   // Load Grunt plugins from the config files in the grunt/ directory
   grunt.loadTasks("grunt");
   require("time-grunt")(grunt);
 
   // Register task for running linters
   grunt.registerTask("lint", [
     "jsonlint",
-    "jshint",
-    "jscs"
+    "jscs",
+    "eslint"
   ]);
 
   // Register task for coverage

Gruntfile.js

@@ -1,6 +1,4 @@
-/**
- * Cleans the dist directory (deletes all files)
- */
+// Cleans the dist directory (deletes all files)
 module.exports = function(grunt) {
 
   grunt.config("clean", {

grunt/clean.js

@@ -1,6 +1,4 @@
-/**
-* Checks to ensure the test coverage meets the minimum thresholds below
-*/
+// Checks to ensure the test coverage meets the minimum thresholds below
 module.exports = function(grunt) {
 
   grunt.config("coverage", {

grunt/coverage-check.js

@@ -2,7 +2,7 @@ module.exports = function(grunt) {
 
   grunt.config("env", {
     coverage: {
-      SRC_DIR_FOR_CODE_COVERAGE: "../tests/coverage/instrument/src/"
+      SRC_DIR_FOR_CODE_COV: "../tests/coverage/instrument/src/"
     }
   });
 

grunt/env.js

@@ -0,0 +1,16 @@
+module.exports = function(grunt) {
+  grunt.config("eslint", {
+    options: {
+      configFile: ".eslintrc.json",
+      format: "node_modules/eslint-formatter-pretty"
+    },
+    javascript: [
+      "src/**/*.js",
+      "grunt/*.js",
+      "tests/unit/**/*.js",
+      "*.js"
+    ]
+  });
+
+  grunt.loadNpmTasks("grunt-eslint");
+};

grunt/eslint.js

@@ -8,7 +8,6 @@ module.exports = function(grunt) {
         "tests/unit/**/*.json",
         "*.json",
         ".jscsrc",
-        ".jshintrc",
         ".npmpackagejsonlintrc"
       ]
     }