Intl Era Monthcode: Constrain tests for Indian calendar #4726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ms2ger
approved these changes
Nov 28, 2025
Adds tests for constraining 31 Chaitra to 30 Chaitra when moving from a leap year to a common year, by the add(), subtract(), or with() methods.
This adds tests for constraining the day when adding months in the Indian calendar. Adding years is already tested in leap-year-indian.js. Test that 31 gets constrained to 30 in 30-day months.
Ms2ger
force-pushed
the
indian-calendar-constrain
branch
from
a2f84e3 to
4c1af80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various tests for constraining day 31 of a month to day 30 when landing in a different month.
As usual, I recommend reviewing
PlainDate/prototype/add/andPlainDate/prototype/with/carefully and spot-checking the others, which are very similar.