Fix constructor-options-calendar-islamic-fallback.js #4681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The defintion of AvailableCalendars in https://tc39.es/proposal-intl-era-monthcode/#sup-availablecalendars is "The List must include the Calendar Type value of every row of Table 1, except the header row." It does said it ONLY include those listed in that Table. so the return list may also include "islamic" and "islamic-rgsa" and therefore the test is incorrect. so we should get availableCalendars from calling Intl.supportedValuesOf("calendar") instead
Contributor
|
I need to think about this, if it's still possible to write a meaningful test for this feature at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The defintion of AvailableCalendars in https://tc39.es/proposal-intl-era-monthcode/#sup-availablecalendars is "The List must include the Calendar Type value of every row of Table 1, except the header row." It does said it ONLY include those listed in that Table. so the return list may also include "islamic" and "islamic-rgsa" and therefore the test is incorrect.
so we should get availableCalendars from calling Intl.supportedValuesOf("calendar") instead
@ben-allen @sffc