Skip to content

Additional operators and unit tests #189

Open
@jrobinson01

Description

@jrobinson01

Apologies for the title. This is probably going to be a bit of a hodge podge and more discussion than "issue".

First, I added some new operators, and some construction type things... like fromEvent, fromPromise, etc.
https://github.com/jrobinson01/proposal-observable

I was going to create a PR but I also wanted to write some tests first. I started by including the existing future/filter spec and had high hopes of making that pass. I haven't gotten very far, which leads to my first questions.

The filter spec has a few tests that I'm not sure how to make pass. These are all to do with return values:
https://github.com/tc39/proposal-observable/blob/master/test/future/filter.js#L73
https://github.com/tc39/proposal-observable/blob/master/test/future/filter.js#L94
https://github.com/tc39/proposal-observable/blob/master/test/future/filter.js#L115
https://github.com/tc39/proposal-observable/blob/master/test/future/filter.js#L136

Given this filter implementation:
https://github.com/jrobinson01/proposal-observable/blob/master/src/Observable.js#L369
what is missing to satisfy these tests?

Concerning the test for complete:
https://github.com/tc39/proposal-observable/blob/master/test/future/filter.js#L120

I haven't been able to get either of those to pass. I'm a bit confused by "Complete values are forwarded". Did we decide what complete should and should not do? Should it pass a value at all? If so, what value?

Finally, some more general questions...

Is this proposal still active?

I see mention of filter and map existing in this proposal at one point. I assume they were since removed but am not sure I understand why?

Is it worth creating a PR if I can get test coverage?

I feel like I had more questions but I guess this is plenty for one issue.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions