-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset settings for different URLs #13
Comments
Might use onHistoryStateUpdated. See Chrome docs and MDN docs. |
As mentioned in 0533304,
onHistoryStateUpdated seems like an cleaner solution (from the perspective of the user), but it might require more invasive permissions. |
I think all of the session storage should be cleared and the content scripts wiped clean. That means
|
For now, I'll tie this to the DM logo. It'd be useful to tie each DM page to the browser tab, though. Once the tab closes, the state would be cleared. I wanted to originally do this via the browser's sessionStorage property, but that would increase complexity by messaging between the extension page's background scripts and the browser's content scripts (eg. loading the values of the checkbox in the extension based on the value in the browser). It'd be more accurate, though. |
Fixes #13 temporarily. Will resubmit to the Chrome Web Store after this change. Users can now reset the video onscreen and the extension properties by clicking the Dance Monkey icon. I'd like to create a more intuitive method of doing this, though! I may switch to using browser local storage to save default configurations for saved videos once I implement the Saved Videos page.
No description provided.
The text was updated successfully, but these errors were encountered: