Upgrading to v4

[tarampampam]

Hey everyone who comes here!

First of all, I'll repeat the link to the upgrade guide - it might be useful if someone missed it.

This issue is created to accumulate all the problems you may have encountered during the upgrade. Probably something doesn't work as expected, or I may have missed something important in the upgrade guide - either way, feel free to post anything related to the upgrade here, with a minimal amount of details (but enough to understand the issue you encountered), and I'll do my best to fix it or suggest a solution as soon as possible.

Also, if you'd like to share any feedback, please don't hesitate to do so here! :D

[ToshY]

Hey @tarampampam 👋

As I do not have any custom templates/variables/functions and I saw no environment variables were removed (nor did I use any of the renamed variables), the upgrade from 3.8 to 4.0 was painless (upgraded on production server with docker compose/traefik).

Thank you for your continued effort.

p.s.

I will check how the container is doing after running for a while to check if there are any noticable changes with regards to the previous version.

[tarampampam]

@ToshY Thanks for your feedback! Please note that the logging level was changed from warn to info for the Docker image by default - you will probably need to set it back to warn after testing to keep the Docker logs clean

[ToshY]

@ToshY Thanks for your feedback! Please note that the logging level was changed from warn to info for the Docker image by default - you will probably need to set it back to warn after testing to keep the Docker logs clean

In 3.8 I did not notice any warn logs, however in 4.0 I see it emits warn for /404.html:

{"ts":1777801594.0574265,"level":"warn","msg":"Client error","duration":5003000,"status_code":404,"response_size":23806,"url":"/404.html","method":"GET","useragent":"Go-http-client/2.0","referer":"","content_type":"text/html; charset=utf-8","host":"auth.example.com","remote_addr":"172.21.0.4:49648"}

.env / compose.yaml

###> Image versions ###
#ERROR_PAGES_IMAGE_VERSION="3.8"
ERROR_PAGES_IMAGE_VERSION="4.0"
###< Image versions ###

###> Error pages ###
ERROR_PAGES_TEMPLATE_NAME="connection"
ERROR_PAGES_SHOW_DETAILS="true"
ERROR_PAGES_SEND_SAME_HTTP_CODE="true"
###< Error pages ###

name: error-pages
services:
  error-pages:
    image: ghcr.io/tarampampam/error-pages:${ERROR_PAGES_IMAGE_VERSION}
    security_opt:
      - no-new-privileges:true
    restart: always
    environment:
      LOG_LEVEL: 'warn'
      TEMPLATE_NAME: ${ERROR_PAGES_TEMPLATE_NAME:-ghost}
      SHOW_DETAILS: ${ERROR_PAGES_SHOW_DETAILS:-}
      DISABLE_L10N: ${ERROR_PAGES_DISABLE_L10N:-}
      DEFAULT_ERROR_PAGE: ${ERROR_PAGES_DEFAULT_ERROR_PAGE:-404}
      READ_BUFFER_SIZE: ${ERROR_PAGES_READ_BUFFER_SIZE:-4096}
      PROXY_HTTP_HEADERS: ${ERROR_PAGES_PROXY_HTTP_HEADERS:-}
      SEND_SAME_HTTP_CODE: ${ERROR_PAGES_SEND_SAME_HTTP_CODE:-true}
    labels:
      traefik.enable: true
      traefik.docker.network: proxy
      traefik.http.routers.error-pages.tls: true
      traefik.http.routers.error-pages.rule: HostRegexp(`.+`)
      traefik.http.routers.error-pages.priority: 10
      traefik.http.routers.error-pages.entrypoints: websecure
      traefik.http.routers.error-pages.service: error-pages
      traefik.http.services.error-pages.loadbalancer.server.port: 8080
    networks:
      - error-pages
      - proxy

  wait:
    image: waisbrot/wait
    environment:
      TARGETS: error-pages:8080
      TIMEOUT: 30
    networks:
      - error-pages

networks:
  error-pages:
    driver: bridge
  proxy:
    external: true

Is it correct that it now emits this warning and should I set my log level to error in 4.0 instead?

[tarampampam]

Good catch. Regarding the "access log" logic, I think it's totally fine, coz everything with an HTTP code >= 400 should be logged at a level higher than info:

error-pages/internal/httpserver/middleware/access_log.go

Lines 70 to 79 in 11aebaa

	switch {
	case status >= http.StatusInternalServerError: // 500
	message, level = "Server error", logger.ErrorLevel
	case status >= http.StatusBadRequest: // 400
	message, level = "Client error", logger.WarnLevel
	case status >= http.StatusMultipleChoices: // 300
	message = "Redirection"
	case status >= http.StatusContinue && status < http.StatusOK: // 1xx
	message = "Informational"
	}

However, since that's expected for the error pages - I started to have some doubts :D

Anyway, thanks for pointing this out!

[tarampampam]

@ToshY Man, you've won - I've removed the log-level escalation for 4xx/5xx in the access log