Implement all the remaining string conversions.

Including with dispatch on potentially hijacked classes, and all
the weird null handling corner cases.

Author: sjrd

loader.mjs

@@ -60,6 +60,7 @@ const scalaJSHelpers = {
   booleanToString: (b) => b ? "true" : "false",
   charToString: (c) => String.fromCharCode(c),
   intToString: (i) => "" + i,
+  longToString: (l) => "" + l, // l must be a bigint here
   doubleToString: (d) => "" + d,
   stringConcat: (x, y) => ("" + x) + y, // the added "" is for the case where x === y === null
   isString: (x) => typeof x === 'string',

test-suite/src/main/scala/testsuite/core/ToStringTest.scala

@@ -10,16 +10,34 @@ object ToStringTest {
     testBoolean(true, "true") &&
       testBoolean(false, "false") &&
       !testBoolean(true, "tru") && // confidence test
+      testAny(true, "true") &&
+      testAny(false, "false") &&
       testChar('A', "A") &&
-      testByte(54, "54") &&
-      testShort(6543, "6543") &&
+      testAny('A', "A") &&
+      testByte(54.toByte, "54") &&
+      testAny(54.toByte, "54") &&
+      testShort(6543.toShort, "6543") &&
+      testAny(6543.toShort, "6543") &&
       testInt(-3423456, "-3423456") &&
-      //testLong(1234567891011L, "1234567891011") && // TODO does not work yet
+      testAny(-3423456, "-3423456") &&
+      testLong(1234567891011L, "1234567891011") &&
+      testAny(1234567891011L, "1234567891011") &&
       testFloat(1.5f, "1.5") &&
+      testAny(1.5f, "1.5") &&
       testDouble(1.4, "1.4") &&
+      testAny(1.4, "1.4") &&
       testString("foo", "foo") &&
+      testAny("foo", "foo") &&
       testString(null, "null") &&
+      testAny(null, "null") &&
       testUndef((), "undefined") &&
+      testAny((), "undefined") &&
+      testMyToString(new MyToString(), "my toString") &&
+      testMyToString(null, "null") &&
+      testAny(new MyToString(), "my toString") &&
+      testToStringNull(new ToStringNull(), "null") &&
+      testToStringNull(null, "null") &&
+      testAny(new ToStringNull(), "null") &&
       testConcat(1, "foo", "1foo") &&
       testConcat(2, null, "2null")
   }
@@ -54,6 +72,25 @@ object ToStringTest {
   def testUndef(x: Unit, expected: String): Boolean =
     "" + x == expected
 
+  def testMyToString(x: MyToString, expected: String): Boolean =
+    "" + x == expected
+
+  def testToStringNull(x: ToStringNull, expected: String): Boolean =
+    "" + x == expected
+
+  def testAny(x: Any, expected: String): Boolean =
+    "" + x == expected
+
   def testConcat(x: Int, y: String, expected: String): Boolean =
     "" + x + y == expected
+
+  class MyToString {
+    @noinline
+    override def toString(): String = "my toString"
+  }
+
+  class ToStringNull {
+    @noinline
+    override def toString(): String = null // evil
+  }
 }