You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think in this case we wouldn't sort the array items because there could be inadvertent behavioral changes with that. So there might be edge cases that make this sorting not feasible. There's also deciding what to do when there's a mixture of single class strings and multi-class strings in the array.
I'm not well-versed enough with CVA to make that call though.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
-
It would be nice to sort the array values inside
cva()
.This is a tough heuristic to get right because there are cases where you can't/don't want these to be sorted.
I think there's a reasonable middle ground though that would be useful.
Sorting these classes would be the main use case:
Where this gets tricky is when you have an array with items that each have multiple classes:
I think in this case we wouldn't sort the array items because there could be inadvertent behavioral changes with that. So there might be edge cases that make this sorting not feasible. There's also deciding what to do when there's a mixture of single class strings and multi-class strings in the array.
I'm not well-versed enough with CVA to make that call though.
Beta Was this translation helpful? Give feedback.
All reactions