You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
and then pass it to the precompile function as is.
We need to do this in order to avoid copying the code of build for compiling autogenerated ASTs. Copying the code of build can lead to bugs due to accidental omissions while copying or modifying (as I recently experienced in PR #2083). Also, code duplication can lead to unsynchronized code in different parts of the codebase.
The text was updated successfully, but these errors were encountered:
Correct. Then, we need to extract the current code of build in an auxiliary function, and add two public accesses to it: one without parsedModules and one with it.
We need to add
parseModules
optional parameter tobuild
, like this:and then pass it to the
precompile
function as is.We need to do this in order to avoid copying the code of
build
for compiling autogenerated ASTs. Copying the code of build can lead to bugs due to accidental omissions while copying or modifying (as I recently experienced in PR #2083). Also, code duplication can lead to unsynchronized code in different parts of the codebase.The text was updated successfully, but these errors were encountered: