Skip to content

Commit 8e4b3bb

Browse files
authoredFeb 12, 2024
Merge pull request #149 from syslabcom/scrum-1939-listing-publication
Show publication reference in listings
2 parents 93b95b3 + 3d693c8 commit 8e4b3bb

File tree

2 files changed

+18
-14
lines changed

2 files changed

+18
-14
lines changed
 

‎src/recensio/plone/browser/listing.py

+12-7
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,6 @@
1111
from ZTUtils import make_query
1212

1313

14-
class RecensioFacetedQueryHandler(FacetedQueryHandler):
15-
"""Add recensio capabilities"""
16-
17-
def punctuated_title_and_subtitle(self, obj):
18-
return punctuated_title_and_subtitle(obj)
19-
20-
2114
class ResultsListing(BrowserView):
2215
"""Lists search results."""
2316

@@ -35,6 +28,14 @@ class ListingBase(BrowserView):
3528
def punctuated_title_and_subtitle(self, obj):
3629
return punctuated_title_and_subtitle(obj)
3730

31+
def publication_reference(self, item):
32+
obj = item.getObject()
33+
view = api.content.get_view(
34+
context=obj, request=self.request, name="breadcrumbs_view"
35+
)
36+
breadcrumbs = list(view.breadcrumbs())[2:-1]
37+
return ", ".join([crumb["Title"] for crumb in breadcrumbs])
38+
3839
@property
3940
def rss_url(self):
4041
portal_url = api.portal.get().absolute_url()
@@ -56,6 +57,10 @@ def translate(self, msgid):
5657
)
5758

5859

60+
class RecensioFacetedQueryHandler(FacetedQueryHandler, ListingBase):
61+
"""Add recensio capabilities"""
62+
63+
5964
class ReviewSectionsListing(ListingBase):
6065
@property
6166
def title(self):

‎src/recensio/plone/browser/templates/results-listing.pt

+6-7
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,9 @@
171171
</span>
172172

173173
<span class="review-author"
174+
tal:define="
175+
publication_reference python: view.publication_reference(result);
176+
"
174177
tal:condition="python:is_review and review_authors"
175178
>
176179
<br />
@@ -183,13 +186,9 @@
183186
/
184187
</tal:c></tal:repeatblock></tal:nameblock></tal:author><tal:block tal:condition="result/get_publication_title | nothing">,
185188
</tal:block>
186-
<tal:block tal:condition="result/get_publication_title | nothing">
187-
<tal:journal tal:condition="result/get_publication_title | nothing"
188-
i18n:translate="source_journal"
189-
>in:
190-
<tal:block i18n:name="publication_volume_issue"><tal:publication tal:replace="result/get_publication_title" />,
191-
<tal:block replace="result/get_volume_title" /><tal:comma tal:condition="result/get_issue_title|nothing">,
192-
</tal:comma><tal:block replace="result/get_issue_title" /></tal:block>
189+
<tal:block tal:condition="publication_reference">
190+
<tal:journal i18n:translate="source_journal">in:
191+
<tal:block i18n:name="publication_volume_issue"><tal:publication tal:replace="publication_reference" /></tal:block>
193192
</tal:journal><tal:pages tal:condition="result_obj/page_start_end_in_print|nothing">,
194193
<tal:block i18n:translate="text_pages">p.</tal:block>
195194
<tal:block tal:replace="result_obj/page_start_end_in_print" /></tal:pages>

0 commit comments

Comments
 (0)