fix(core): fix double call to StartWorkers() function when policy are reloaded (#59)

msardara · web-flow · commit bd025c6954c4 · 2024-02-13T11:07:07.000-05:00
Signed-off-by: Mauro Sardara &lt;msardara@cisco.com&gt;
diff --git a/core/policyengine/policyengine.go b/core/policyengine/policyengine.go
@@ -94,6 +94,9 @@ func (s *PolicyEngine) Init(conf map[string]interface{}) (err error) {
 			logger.Error.Printf("Unable to compile local policies from directory %s, %v", s.config.PoliciesPath, err)
 			return
 		}
+
+		// start workers
+		s.pi.StartWorkers()
 	} else {
 		s.policyMonitor, err = monitor.NewPolicyMonitor(s.config, s.createPolicyInterpreter, s.out)
 		if err != nil {
@@ -197,9 +200,6 @@ func (s *PolicyEngine) createPolicyInterpreter() (*engine.PolicyInterpreter[*com
 		return nil, err
 	}
 
-	// start workers
-	pi.StartWorkers()
-
 	return pi, nil
 }
 

Original file line number	Diff line number	Diff line change
`@@ -94,6 +94,9 @@ func (s *PolicyEngine) Init(conf map[string]interface{}) (err error) {`
`94`	`94`	`logger.Error.Printf("Unable to compile local policies from directory %s, %v", s.config.PoliciesPath, err)`
`95`	`95`	`return`
`96`	`96`	`}`
	`97`	`+`
	`98`	`+ // start workers`
	`99`	`+ s.pi.StartWorkers()`
`97`	`100`	`} else {`
`98`	`101`	`s.policyMonitor, err = monitor.NewPolicyMonitor(s.config, s.createPolicyInterpreter, s.out)`
`99`	`102`	`if err != nil {`
`@@ -197,9 +200,6 @@ func (s PolicyEngine) createPolicyInterpreter() (engine.PolicyInterpreter[*com`
`197`	`200`	`return nil, err`
`198`	`201`	`}`
`199`	`202`
`200`		`- // start workers`
`201`		`- pi.StartWorkers()`
`202`		`-`
`203`	`203`	`return pi, nil`
`204`	`204`	`}`
`205`	`205`