Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: todo resource request in workshop should be scheduled to the worker cluster #146

Open
SaphMB opened this issue Oct 29, 2024 · 2 comments

Comments

@SaphMB
Copy link
Member

SaphMB commented Oct 29, 2024

In the Writing your first Promise section of the workshop, the learner is told to verify that their todo app request has been deployed to the the worker cluster with:

kubectl --context $WORKER get deployments

However, the app has no selectors to ensure that is is deployed on the worker cluster and can end up on the platform cluster.

Acceptance
Given a user has followed the instructions in Writing your first Promise
When they apply the app Promise
Then the resource is consistently scheduled to the worker cluster

@SaphMB SaphMB changed the title fix: todo app in workshop should be scheduled to the worker cluster fix: todo resource request in workshop should be scheduled to the worker cluster Oct 29, 2024
@kirederik kirederik self-assigned this Nov 4, 2024
@kirederik
Copy link
Member

do we know what's the context behind this issue? Where they running it locally or via Instruqt? Was this reported by a single user or many?

It feels user error as it should never happen if you follow the instructions in order.

  • The platform cluster is scheduled with strictMatchLabels: true and the label environment=platform
  • This snippet of code should block Kratix from considering the Platform destination (since the above is true)

Did some testing on instruqt and could not reproduce

Image

@SaphMB
Copy link
Member Author

SaphMB commented Nov 4, 2024

@kirederik Interesting, they were doing the workshop on Instruqt and reported observing that the the app could be scheduled to the platform. Two people mentioned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants