Commit 2ded754
committed
minor #2069 [ux.symfony.com] Fix rendering/color issues on Map page (Kocal)
This PR was squashed before being merged into the 2.x branch.
Discussion
----------
[ux.symfony.com] Fix rendering/color issues on Map page
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | yes <!-- please update src/**/CHANGELOG.md files -->
| Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License | MIT
<!--
Replace this notice by a description of your feature/bugfix.
This will help reviewers and should be a good start for the documentation.
Additionally (see https://symfony.com/releases):
- Always add tests and ensure they pass.
- For new features, provide some code snippets to help understand usage.
- Features and deprecations must be submitted against branch main.
- Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
- Never break backward compatibility (see https://symfony.com/bc).
-->
It looks like we have some visual issues in light mode on the Map page, we can't see the menu:
<img width="1501" alt="Capture d’écran 2024-08-15 à 07 42 21" src="https://github.com/user-attachments/assets/6a39c912-3cc3-4b73-82a5-16a5aa751d1e">
And we miss the `composer require ...` thing.
I've Replaced the usage of the new component `Hero` (introduced in #2053) by the good old `PackageHeader` component.
This is the quickest solution right now to correctly render UX Map page, and it gives us some times to improve this `Hero` component and re-use it in all UX package pages.
**EDIT:** I've seen with `@smnandre` for some minor adjustements:
<img width="1512" alt="image" src="https://github.com/user-attachments/assets/8544f46a-37aa-4b1e-964e-380174a2d0c5">
<img width="1510" alt="image" src="https://github.com/user-attachments/assets/b7617ebe-f014-4e50-a3b3-c78f5045b552">
Commits
-------
c3a8806 [ux.symfony.com] Fix rendering/color issues on Map pageFile tree
3 files changed
+14
-11
lines changed- ux.symfony.com
- assets/styles/components
- src/Service
- templates/ux_packages
3 files changed
+14
-11
lines changedLines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | | - | |
41 | | - | |
| 40 | + | |
42 | 41 | | |
43 | 42 | | |
44 | 43 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
15 | 18 | | |
16 | 19 | | |
17 | 20 | | |
| |||
0 commit comments