[Messenger] Document stamps in HandleTrait::handle #20851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Fan2Shrek, This looks good to me. |
OskarStark
reviewed
Apr 2, 2025
messenger.rst
Outdated
| @@ -2512,6 +2512,15 @@ wherever you need a query bus behavior instead of the ``MessageBusInterface``:: | |||
| } | |||
| } | |||
|
|
|||
| You also can also specify stamps when handling a message. For example, you can | |||
There was a problem hiding this comment.
What does specify mean here? Is it about adding new stamps to the message? What if you add a stamp of the same type that some existing stamp: is it appended or overwritten? Thanks!
There was a problem hiding this comment.
Good points! I committed some refinements. Does it look good to you?
carsonbot
changed the title
Spomky
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #20842