Enable "native_constant_invocation" CS rule

nicolas-grekas · nicolas-grekas · commit 7af3179c2915 · 2020-09-02T18:06:40.000+02:00
diff --git a/PropertyAccessor.php b/PropertyAccessor.php
@@ -246,7 +246,7 @@ public function setValue(&$objectOrArray, $propertyPath, $value)
      */
     public static function handleError($type, $message, $file, $line, $context = [])
     {
-        if (E_RECOVERABLE_ERROR === $type) {
+        if (\E_RECOVERABLE_ERROR === $type) {
             self::throwInvalidArgumentException($message, debug_backtrace(false), 1);
         }
 
@@ -961,7 +961,7 @@ public static function createCache($namespace, $defaultLifetime, $version, Logge
         }
 
         $apcu = new ApcuAdapter($namespace, $defaultLifetime / 5, $version);
-        if ('cli' === \PHP_SAPI && !filter_var(ini_get('apc.enable_cli'), FILTER_VALIDATE_BOOLEAN)) {
+        if ('cli' === \PHP_SAPI && !filter_var(ini_get('apc.enable_cli'), \FILTER_VALIDATE_BOOLEAN)) {
             $apcu->setLogger(new NullLogger());
         } elseif (null !== $logger) {
             $apcu->setLogger($logger);
diff --git a/StringUtil.php b/StringUtil.php
@@ -44,7 +44,7 @@ private function __construct()
      */
     public static function singularify($plural)
     {
-        @trigger_error('StringUtil::singularify() is deprecated since Symfony 3.1 and will be removed in 4.0. Use Symfony\Component\Inflector\Inflector::singularize instead.', E_USER_DEPRECATED);
+        @trigger_error('StringUtil::singularify() is deprecated since Symfony 3.1 and will be removed in 4.0. Use Symfony\Component\Inflector\Inflector::singularize instead.', \E_USER_DEPRECATED);
 
         return Inflector::singularize($plural);
     }

Original file line number	Diff line number	Diff line change
`@@ -246,7 +246,7 @@ public function setValue(&$objectOrArray, $propertyPath, $value)`
`246`	`246`	`*/`
`247`	`247`	`public static function handleError($type, $message, $file, $line, $context = [])`
`248`	`248`	`{`
`249`		`- if (E_RECOVERABLE_ERROR === $type) {`
	`249`	`+ if (\E_RECOVERABLE_ERROR === $type) {`
`250`	`250`	`self::throwInvalidArgumentException($message, debug_backtrace(false), 1);`
`251`	`251`	`}`
`252`	`252`
`@@ -961,7 +961,7 @@ public static function createCache($namespace, $defaultLifetime, $version, Logge`
`961`	`961`	`}`
`962`	`962`
`963`	`963`	`$apcu = new ApcuAdapter($namespace, $defaultLifetime / 5, $version);`
`964`		`- if ('cli' === \PHP_SAPI && !filter_var(ini_get('apc.enable_cli'), FILTER_VALIDATE_BOOLEAN)) {`
	`964`	`+ if ('cli' === \PHP_SAPI && !filter_var(ini_get('apc.enable_cli'), \FILTER_VALIDATE_BOOLEAN)) {`
`965`	`965`	`$apcu->setLogger(new NullLogger());`
`966`	`966`	`} elseif (null !== $logger) {`
`967`	`967`	`$apcu->setLogger($logger);`
Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ private function __construct()`
`44`	`44`	`*/`
`45`	`45`	`public static function singularify($plural)`
`46`	`46`	`{`
`47`		`- @trigger_error('StringUtil::singularify() is deprecated since Symfony 3.1 and will be removed in 4.0. Use Symfony\Component\Inflector\Inflector::singularize instead.', E_USER_DEPRECATED);`
	`47`	`+ @trigger_error('StringUtil::singularify() is deprecated since Symfony 3.1 and will be removed in 4.0. Use Symfony\Component\Inflector\Inflector::singularize instead.', \E_USER_DEPRECATED);`
`48`	`48`
`49`	`49`	`return Inflector::singularize($plural);`
`50`	`50`	`}`