Merge branch '6.0' into 6.1

* 6.0: (23 commits)
  Fix composer on appveyor
  fix bootstrap_3_layout ChoiceType's expanded label_html
  [Messenger][Security/Core] Remove legacy class aliases
  [PropertyAccess] Fix typo in PropertyAccessor::readProperty() DocBlock
  [PropertyInfo] PhpStanExtractor namespace missmatch issue
  [VarExporter] Fix exporting objects with readonly properties
  [ExpressionLanguage] Fix matches when the regexp is not valid
  [Messenger] Add mysql indexes back and work around deadlocks using soft-delete
  Add BC layer to handle old objects already present in cache
  [RateLimiter] Always store SlidingWindows with an expiration set
  [Validator] Fix File constraint invalid max size exception message
  [Console] Fix exit status on uncaught exception with negative code
  [Validator] fix #43345 @Assert\DivisibleBy
  [HttpClient] fix 303 after PUT and sending chunked requests
  [HttpClient] always send Content-Type when a body is passed
  [HttpClient] always send Content-Length when a body is passed
  [HttpClient] fix sending Content-Length/Type for POST
  Fix merge
  [HttpClient] fix sending PUT requests with curl
  Fix locales format in CrowdinProvider
  ...

Author: nicolas-grekas

Application.php

@@ -179,7 +179,7 @@ public function run(InputInterface $input = null, OutputInterface $output = null
             $exitCode = $e->getCode();
             if (is_numeric($exitCode)) {
                 $exitCode = (int) $exitCode;
-                if (0 === $exitCode) {
+                if ($exitCode <= 0) {
                     $exitCode = 1;
                 }
             } else {

Tests/ApplicationTest.php

@@ -1172,6 +1172,25 @@ public function testRunDispatchesExitCodeOneForExceptionCodeZero()
         $this->assertTrue($passedRightValue, '-> exit code 1 was passed in the console.terminate event');
     }
 
+    /**
+     * @testWith [-1]
+     *           [-32000]
+     */
+    public function testRunReturnsExitCodeOneForNegativeExceptionCode($exceptionCode)
+    {
+        $exception = new \Exception('', $exceptionCode);
+
+        $application = $this->getMockBuilder(Application::class)->setMethods(['doRun'])->getMock();
+        $application->setAutoExit(false);
+        $application->expects($this->once())
+            ->method('doRun')
+            ->willThrowException($exception);
+
+        $exitCode = $application->run(new ArrayInput([]), new NullOutput());
+
+        $this->assertSame(1, $exitCode, '->run() returns exit code 1 when exception code is '.$exceptionCode);
+    }
+
     public function testAddingOptionWithDuplicateShortcut()
     {
         $this->expectException(\LogicException::class);