Reduce common control flows

Author: alexandre-daubois

Completion/CompletionInput.php

@@ -123,13 +123,13 @@ public function bind(InputDefinition $definition): void
         if ($this->currentIndex >= \count($this->tokens)) {
             if (!isset($this->arguments[$argumentName]) || $this->definition->getArgument($argumentName)->isArray()) {
                 $this->completionName = $argumentName;
-                $this->completionValue = '';
             } else {
                 // we've reached the end
                 $this->completionType = self::TYPE_NONE;
                 $this->completionName = null;
-                $this->completionValue = '';
             }
+
+            $this->completionValue = '';
         }
     }
 

Tests/Logger/ConsoleLoggerTest.php

@@ -151,11 +151,7 @@ public function testContextReplacement()
 
     public function testObjectCastToString()
     {
-        if (method_exists($this, 'createPartialMock')) {
-            $dummy = $this->createPartialMock(DummyTest::class, ['__toString']);
-        } else {
-            $dummy = $this->createPartialMock(DummyTest::class, ['__toString']);
-        }
+        $dummy = $this->createPartialMock(DummyTest::class, ['__toString']);
         $dummy->method('__toString')->willReturn('DUMMY');
 
         $this->getLogger()->warning($dummy);