-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Angular 19 #1980
Comments
Here's the package.json override you'll need to avoid this "overrides": {
"@swimlane/ngx-charts": {
"@angular/animations@": ">=18.0.0",
"@angular/cdk@": ">=18.0.0",
"@angular/common@": ">=18.0.0",
"@angular/core@": ">=18.0.0",
"@angular/forms@": ">=18.0.0",
"@angular/platform-browser@": ">=18.0.0",
"@angular/platform-browser-dynamic@": ">=18.0.0",
"@angular/router@": ">=18.0.0"
}
} IMO it would be best if folks use the >= syntax instead of explicit versions with ^. Less specific version pinning could make contributions easier as folks could actually test with Angular 19 and report bugs, instead of being blocked. |
Any news? |
@marjan-georgiev I've noticed you've committed recently, and I wanted to tag you in case this thread went unnoticed. It might be worth considering updating the "peerDependencies": {
"@angular/animations": "17.x || 18.x",
"@angular/cdk": "17.x || 18.x",
"@angular/core": "17.x || 18.x",
"@angular/common": "17.x || 18.x",
"@angular/forms": "17.x || 18.x",
"@angular/platform-browser": "17.x || 18.x",
"@angular/platform-browser-dynamic": "17.x || 18.x",
"rxjs": "7.x"
} to: "peerDependencies": {
"@angular/animations": ">=17.0.0",
"@angular/cdk": ">=17.0.0",
"@angular/core": ">=17.0.0",
"@angular/common": ">=17.0.0",
"@angular/forms": ">=17.0.0",
"@angular/platform-browser": ">=17.0.0",
"@angular/platform-browser-dynamic": ">=17.0.0",
"rxjs": "7.x"
} The release notes already state that it is compatible with Angular 18. Anyone who wants to test it with Angular 19 understands they are doing so at their own risk, as the creators have not officially tested it. This would allow those who wish to experiment with Angular 19 to give it a try. Thank you very much for your work. It's a fantastic library. Best regards! |
ngx-charts/projects/swimlane/ngx-charts/package.json
Line 35 in 61ce343
The text was updated successfully, but these errors were encountered: