Skip to content

The Swift 5 language mode ought to be a resting place #79083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
groue opened this issue Jan 31, 2025 · 0 comments
Open

The Swift 5 language mode ought to be a resting place #79083

groue opened this issue Jan 31, 2025 · 0 comments
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. triage needed This issue needs more specific labels

Comments

@groue
Copy link

groue commented Jan 31, 2025

Description

I can not upgrade RxGRDB (swift-tools-version: 5.7), that depends on RxSwift (swift-tools-version: 5.5) to GRDB 7 (swift-tools-version: 6.0) without compiler warnings: RxSwiftCommunity/RxGRDB#72

This makes no sense, because RxGRDB and RxSwift declare that they don't know anything about Swift 6.

Those undesired warnings are unacceptable.

To repeat the title of this issue: The Swift 5 language mode ought to be a resting place.

Reproduction

Build RxGRDB at RxSwiftCommunity/RxGRDB@04ea590

Expected behavior

No warning.

Environment

swift-driver version: 1.115.1 Apple Swift version 6.0.3 (swiftlang-6.0.3.1.10 clang-1600.0.30.1)
Target: arm64-apple-macosx14.0

Additional information

Quoting https://hachyderm.io/@groue/113924602704476111 (colorful language amended):

I did not upgrade GRDB to Swift 6 and spent MONTHS sweating my concurrency annotations to be rewarded with such a stupid punishment. RxGRDB should be able to stay at Swift 5 without a single warning.

@groue groue added bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. triage needed This issue needs more specific labels labels Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. triage needed This issue needs more specific labels
Projects
None yet
Development

No branches or pull requests

1 participant