Skip to content

Commit 91f816c

Browse files
authored
rdar://69448176 (Fix and re-enable test related to "ParallelTestsPkg") (#3626)
We disabled these a while ago due to issues we had with using XCTest from the sueprior with an inferior SwiftPM. The underlying compiler issue should be fixed at this point and we can re-enable the tests.
1 parent 17f6f21 commit 91f816c

File tree

4 files changed

+0
-18
lines changed

4 files changed

+0
-18
lines changed

Tests/FunctionalTests/CFamilyTargetTests.swift

-3
Original file line numberDiff line numberDiff line change
@@ -86,9 +86,6 @@ class CFamilyTargetTestCase: XCTestCase {
8686
}
8787

8888
func testObjectiveCPackageWithTestTarget() throws {
89-
// <rdar://problem/70382477> Fix and re-enable tests which run `swift test` on newly created packages
90-
try XCTSkipIf(true)
91-
9289
#if os(macOS)
9390
fixture(name: "CFamilyTargets/ObjCmacOSPackage") { prefix in
9491
// Build the package.

Tests/FunctionalTests/MiscellaneousTests.swift

-9
Original file line numberDiff line numberDiff line change
@@ -213,9 +213,6 @@ class MiscellaneousTestCase: XCTestCase {
213213
}
214214

215215
func testSwiftTestParallel() throws {
216-
// <rdar://problem/69448176> Fix and re-enable test related to "ParallelTestsPkg"
217-
try XCTSkipIf(true)
218-
219216
fixture(name: "Miscellaneous/ParallelTestsPkg") { prefix in
220217
// First try normal serial testing.
221218
do {
@@ -261,9 +258,6 @@ class MiscellaneousTestCase: XCTestCase {
261258
}
262259

263260
func testSwiftTestFilter() throws {
264-
// <rdar://problem/69448176> Fix and re-enable test related to "ParallelTestsPkg"
265-
try XCTSkipIf(true)
266-
267261
fixture(name: "Miscellaneous/ParallelTestsPkg") { prefix in
268262
let (stdout, _) = try SwiftPMProduct.SwiftTest.execute(["--filter", ".*1", "-l"], packagePath: prefix)
269263
XCTAssertMatch(stdout, .contains("testExample1"))
@@ -280,9 +274,6 @@ class MiscellaneousTestCase: XCTestCase {
280274
}
281275

282276
func testSwiftTestSkip() throws {
283-
// <rdar://problem/69448176> Fix and re-enable test related to "ParallelTestsPkg"
284-
try XCTSkipIf(true)
285-
286277
fixture(name: "Miscellaneous/ParallelTestsPkg") { prefix in
287278
let (stdout, _) = try SwiftPMProduct.SwiftTest.execute(["--skip", "ParallelTestsTests", "-l"], packagePath: prefix)
288279
XCTAssertNoMatch(stdout, .contains("testExample1"))

Tests/FunctionalTests/SwiftPMXCTestHelperTests.swift

-3
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,6 @@ import Workspace
1717

1818
class SwiftPMXCTestHelperTests: XCTestCase {
1919
func testBasicXCTestHelper() throws {
20-
// <rdar://problem/70382477> Fix and re-enable tests which run `swift test` on newly created packages
21-
try XCTSkipIf(true)
22-
2320
#if os(macOS)
2421
fixture(name: "Miscellaneous/SwiftPMXCTestHelper") { prefix in
2522
// Build the package.

Tests/WorkspaceTests/InitTests.swift

-3
Original file line numberDiff line numberDiff line change
@@ -235,9 +235,6 @@ class InitTests: XCTestCase {
235235
}
236236

237237
func testNonC99NameExecutablePackage() throws {
238-
// <rdar://problem/70382477> Fix and re-enable tests which run `swift test` on newly created packages
239-
try XCTSkipIf(true)
240-
241238
try withTemporaryDirectory(removeTreeOnDeinit: true) { tempDirPath in
242239
XCTAssertTrue(localFileSystem.isDirectory(tempDirPath))
243240

0 commit comments

Comments
 (0)