[NFC][BoundsSafety][LLDB] Refactor the soft trap runtime tests

This refactors the soft trap runtime test so the soft trap runtime
implementation exists in its own file. This has several advantages:

* It let's the runtime be built without debug info which will be the
  common case uses hit
* It prevents the risk of infinite recursion because it isn't safe
  to build the soft trap runtime with -fbounds-safety soft trap mode
  enabled.

Author: delcypher

lldb/test/Shell/BoundsSafety/Inputs/boundsSafetyMockSoftTrapRuntime.c

@@ -0,0 +1,21 @@
+#include <bounds_safety_soft_traps.h>
+#include <ptrcheck.h>
+#include <stdio.h>
+
+#if __CLANG_BOUNDS_SAFETY_SOFT_TRAP_API_VERSION > 0
+#error API version changed
+#endif
+
+#if __has_ptrcheck
+#error Do not compile the runtime with -fbounds-safety enabled due to potential for infinite recursion
+#endif
+
+
+
+void __bounds_safety_soft_trap_s(const char *reason) {
+    printf("BoundsSafety check FAILED: message:\"%s\"\n", reason? reason: "");
+}
+
+void __bounds_safety_soft_trap(void) {
+    printf("BoundsSafety check FAILED\n");
+}

lldb/test/Shell/BoundsSafety/Inputs/boundsSafetySoftTraps.c

@@ -1,17 +1,4 @@
 #include <stdio.h>
-#include <bounds_safety_soft_traps.h>
-
-#if __CLANG_BOUNDS_SAFETY_SOFT_TRAP_API_VERSION > 0
-#error API version changed
-#endif
-
-void __bounds_safety_soft_trap_s(const char *reason) {
-    printf("BoundsSafety check FAILED: message:\"%s\"\n", reason? reason: "");
-}
-
-void __bounds_safety_soft_trap(void) {
-    printf("BoundsSafety check FAILED\n");
-}
 
 int bad_read(int index) {
   int array[] = {0, 1, 2};

lldb/test/Shell/BoundsSafety/boundssafety_soft_trap_call_minimal.test

@@ -1,5 +1,7 @@
 # UNSUPPORTED: system-windows
-# RUN: %clang_host -fbounds-safety -fbounds-safety-soft-traps=call-minimal -g -O0 %S/Inputs/boundsSafetySoftTraps.c -o %t.out
+# RUN: %clang_host -c -fbounds-safety -fbounds-safety-soft-traps=call-minimal -g -O0 %S/Inputs/boundsSafetySoftTraps.c -o %t.o
+# RUN: %clang_host -c -O0 %S/Inputs/boundsSafetyMockSoftTrapRuntime.c -o %t.softtrap_runtime.o
+# RUN: %clang_host %t.o %t.softtrap_runtime.o -o %t.out
 # RUN: %lldb -b -s %s %t.out | FileCheck %s
 b __bounds_safety_soft_trap
 run
@@ -10,9 +12,9 @@ run
 
 # Check that reason for bounds check failing can be seen in the stacktrace
 bt
-# CHECK: * frame #{{.*}}`__bounds_safety_soft_trap{{[ ]+}}
+# CHECK: * frame #{{.*}}`__bounds_safety_soft_trap{{$}}
 # CHECK-NEXT: frame #{{.*}}`__clang_trap_msg$Bounds check failed$indexing above upper bound in 'array[index]'
-# CHECK-NEXT: frame #2{{.*}}`bad_read(index=10) at boundsSafetySoftTraps.c:18
+# CHECK-NEXT: frame #2{{.*}}`bad_read(index=10) at boundsSafetySoftTraps.c:5
 
 # Resume execution
 c

lldb/test/Shell/BoundsSafety/boundssafety_soft_trap_call_with_str.test

@@ -1,5 +1,8 @@
 # UNSUPPORTED: system-windows
-# RUN: %clang_host -fbounds-safety -fbounds-safety-soft-traps=call-with-str -g -O0 %S/Inputs/boundsSafetySoftTraps.c -o %t.out
+# RUN: %clang_host -c -fbounds-safety -fbounds-safety-soft-traps=call-with-str -g -O0 %S/Inputs/boundsSafetySoftTraps.c -o %t.o
+# Note: Building the runtime without debug info is intentional because this is the common case
+# RUN: %clang_host -c -O0 %S/Inputs/boundsSafetyMockSoftTrapRuntime.c -o %t.softtrap_runtime.o
+# RUN: %clang_host %t.o %t.softtrap_runtime.o -o %t.out
 # RUN: %lldb -b -s %s %t.out | FileCheck %s
 b __bounds_safety_soft_trap_s
 run
@@ -10,9 +13,9 @@ run
 
 # Check that reason for bounds check failing can be seen in the stacktrace
 bt
-# CHECK: * frame #{{.*}}`__bounds_safety_soft_trap_s(reason="indexing above upper bound in 'array[index]'")
+# CHECK: * frame #{{.*}}`__bounds_safety_soft_trap_s
 # CHECK-NEXT: frame #{{.*}}`__clang_trap_msg$Bounds check failed$indexing above upper bound in 'array[index]'
-# CHECK-NEXT: frame #2{{.*}}`bad_read(index=10) at boundsSafetySoftTraps.c:18
+# CHECK-NEXT: frame #{{.*}}`bad_read(index=10) at boundsSafetySoftTraps.c:5
 
 # Resume execution
 c