use welcoming language (#79)

Author: tomerd

CONTRIBUTING.md

@@ -68,30 +68,30 @@ We require that your commit messages match our template. The easiest way to do t
 SwiftServiceLifecycle uses XCTest to run tests on both macOS and Linux. While the macOS version of XCTest is able to use the Objective-C runtime to discover tests at execution time, the Linux version is not.
 For this reason, whenever you add new tests **you have to run a script** that generates the hooks needed to run those tests on Linux, or our CI will complain that the tests are not all present on Linux. To do this, merely execute `ruby ./scripts/generate_linux_tests.rb` at the root of the package and check the changes it made.
 
-### Run `./scripts/sanity.sh`
+### Run `./scripts/soundness.sh`
 
-The scripts directory contains a [sanity.sh script](scripts/sanity.sh) 
+The scripts directory contains a [soundness.sh script](scripts/soundness.sh)
 that enforces additional checks, like license headers and formatting style.
-Please make sure to `./scripts/sanity.sh` before pushing a change upstream, otherwise it is likely the PR validation will fail
+Please make sure to `./scripts/soundness.sh` before pushing a change upstream, otherwise it is likely the PR validation will fail
 on minor changes such as a missing `self.` or similar formatting issues.
 
 > The script also executes the above mentioned `generate_linux_tests.rb`.
 
 For frequent contributors, we recommend adding the script as a [git pre-push hook](https://git-scm.com/book/en/v2/Customizing-Git-Git-Hooks), which you can do via executing the following command
-in the project root directory: 
+in the project root directory:
 
 ```bash
 cat << EOF > .git/hooks/pre-push
 #!/bin/bash
 
-if [[ -f "scripts/sanity.sh" ]]; then
-  scripts/sanity.sh
+if [[ -f "scripts/soundness.sh" ]]; then
+  scripts/soundness.sh
 fi
 EOF
 ```
 Which makes the script execute, and only allow the `git push` to complete if the check has passed.
 
-In the case of formatting issues, you can then `git add` the formatting changes, and attempt the push again. 
+In the case of formatting issues, you can then `git add` the formatting changes, and attempt the push again.
 
 ## How to contribute your work
 

docker/docker-compose.yaml

@@ -22,9 +22,9 @@ services:
       - CAP_NET_RAW
       - CAP_NET_BIND_SERVICE
 
-  sanity:
+  soundness:
     <<: *common
-    command: /bin/bash -cl "./scripts/sanity.sh"
+    command: /bin/bash -cl "./scripts/soundness.sh"
 
   test:
     <<: *common

scripts/sanity.sh scripts/soundness.sh

@@ -22,6 +22,22 @@ function replace_acceptable_years() {
     sed -e 's/2017-2018/YEARS/' -e 's/2019-2020/YEARS/' -e 's/2019/YEARS/' -e 's/2020/YEARS/'
 }
 
+printf "=> Checking for unacceptable language... "
+# This greps for unacceptable terminology. The square bracket[s] are so that
+# "git grep" doesn't find the lines that greps :).
+unacceptable_terms=(
+    -e blacklis[t]
+    -e whitelis[t]
+    -e slav[e]
+    -e sanit[y]
+)
+if git grep --color=never -i "${unacceptable_terms[@]}" > /dev/null; then
+    printf "\033[0;31mUnacceptable language found.\033[0m\n"
+    git grep -i "${unacceptable_terms[@]}"
+    exit 1
+fi
+printf "\033[0;32mokay.\033[0m\n"
+
 printf "=> Checking linux tests... "
 FIRST_OUT="$(git status --porcelain)"
 ruby "$here/../scripts/generate_linux_tests.rb" > /dev/null
@@ -47,7 +63,7 @@ else
 fi
 
 printf "=> Checking license headers\n"
-tmp=$(mktemp /tmp/.swift-aws-lambda-sanity_XXXXXX)
+tmp=$(mktemp /tmp/.service-lifecycle-soundness_XXXXXX)
 
 for language in swift-or-c bash dtrace; do
   printf "   * $language... "