Skip to content
This repository was archived by the owner on Jun 24, 2025. It is now read-only.

Conversation

@rge-exafore
Copy link

@rge-exafore rge-exafore commented Jun 21, 2016

@rge-exafore rge-exafore force-pushed the pr-686-copy branch 5 times, most recently from 0c8bc0d to 278ad43 Compare June 28, 2016 21:41
@rge-exafore rge-exafore force-pushed the pr-686-copy branch 2 times, most recently from 5903a86 to a3c20aa Compare June 29, 2016 09:53
@jacobmcnamee jacobmcnamee changed the title PR686 copy WIP: Add Iono correction Jun 30, 2016
/* check if we have a solution, if yes calc iono and tropo correction */
if (soln_flag) {
ionosphere_t i_params;
ionosphere_t *p_i_params = &i_params;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd just use &i_params directly.

Copy link
Author

@rge-exafore rge-exafore Jun 30, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p_i_params is used as a flag and can be set to NULL.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, ok.

@jacobmcnamee
Copy link

Minor inline comments. Rebase, update libswiftnav, and merge when ready.

src/iono.c Outdated
#include "iono.h"
#include "signal.h"

MUTEX_DECL(iono_mutex);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

static

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@rge-exafore rge-exafore changed the title WIP: Add Iono correction Add Iono correction Jun 30, 2016
@jacobmcnamee
Copy link

lgtm

@valeri-atamaniouk valeri-atamaniouk merged commit 9846533 into master Jul 1, 2016
@cbeighley cbeighley deleted the pr-686-copy branch January 18, 2017 18:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants