Skip to content

Commit 8a0f02c

Browse files
committed
Remove the Android-specific files instead of the symlink, which does nothing
1 parent 80819a4 commit 8a0f02c

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

.github/workflows/pull_request.yml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,12 @@ jobs:
3434
include:
3535
- swift-version: 'tag:swift-6.2-DEVELOPMENT-SNAPSHOT-2025-10-25-a'
3636
build-type: 'docker'
37-
build-compiler: '1'
38-
runner: 'self-hosted'
37+
build-compiler: '0'
38+
runner: 'ubuntu-24.04'
39+
- swift-version: 'tag:swift-DEVELOPMENT-SNAPSHOT-2025-10-17-a'
40+
build-type: 'docker'
41+
build-compiler: '0'
42+
runner: 'ubuntu-24.04'
3943
runs-on: ${{ matrix.runner }}
4044
# 16 hour timeout
4145
timeout-minutes: 1080

swift-ci/sdks/android/scripts/build.sh

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -498,10 +498,11 @@ for arch in $archs; do
498498
--foundation-cmake-options=-DCMAKE_SHARED_LINKER_FLAGS= \
499499
--cross-compile-append-host-target-to-destdir=False
500500
# --extra-cmake-options='-DCMAKE_EXTRA_LINK_FLAGS="-Wl,-z,max-page-size=16384"'
501-
# need to remove symlink that gets created in the NDK to the previous arch's build
502-
# or else we get errors like:
501+
# need to remove the arch-specific portion of the Swift resource dir in
502+
# the build directory, through this symlink that we create in the NDK to
503+
# the build directory, or else we get errors like:
503504
# error: could not find module '_Builtin_float' for target 'x86_64-unknown-linux-android'; found: aarch64-unknown-linux-android, at: /home/runner/work/_temp/swift-android-sdk/ndk/android-ndk-r27c/toolchains/llvm/prebuilt/linux-x86_64/sysroot/usr/lib/swift/android/_Builtin_float.swiftmodule
504-
rm -f $ndk_installation/sysroot/usr/lib/swift
505+
rm -f $ndk_installation/sysroot/usr/lib/swift/android
505506
quiet_popd
506507
groupend
507508
done

0 commit comments

Comments
 (0)