Remove checkAllLabel

Author: zoontek

packages/shared-business/__stories__/Filters.stories.tsx

@@ -28,7 +28,6 @@ const status: FilterCheckboxDef<
 > = {
   type: "checkbox",
   label: "Status",
-  checkAllLabel: "All",
   items: [
     { label: "Accepted", value: "Accepted" },
     { label: "Canceled", value: "Canceled" },

packages/shared-business/src/components/Filters.tsx

@@ -20,7 +20,7 @@ import { forwardRef, useCallback, useMemo, useRef, useState } from "react";
 import { Pressable, StyleSheet, Text, View } from "react-native";
 import { P, match } from "ts-pattern";
 import { Simplify } from "type-fest";
-import { DateFormat } from "../utils/i18n";
+import { DateFormat, t } from "../utils/i18n";
 import { DatePickerDate, DatePickerModal } from "./DatePicker";
 
 const styles = StyleSheet.create({
@@ -204,7 +204,6 @@ type FilterCheckboxProps<T> = {
   value: T[] | undefined;
   onPressRemove: () => void;
   autoOpen?: boolean;
-  checkAllLabel?: string;
 };
 
 type CheckAllItem = {
@@ -216,7 +215,6 @@ function FilterCheckbox<T>({
   label,
   items,
   width,
-  checkAllLabel,
   value,
   onValueChange,
   onPressRemove,
@@ -232,23 +230,19 @@ function FilterCheckbox<T>({
     [items, valueSet],
   );
 
-  const allChecked = checkAllLabel != null && valueSet.size === items.length;
+  const allChecked = valueSet.size === items.length;
 
   const listItems = useMemo(() => {
-    if (checkAllLabel == null) {
-      return items;
-    }
-
     const checked: CheckAllItem["checked"] =
       valueSet.size === 0 ? false : valueSet.size === items.length ? true : "mixed";
 
     const checkAllItem: CheckAllItem = {
-      label: checkAllLabel,
+      label: t("common.filters.all"),
       checked,
     };
 
     return [checkAllItem, ...items];
-  }, [items, checkAllLabel, valueSet]);
+  }, [items, valueSet]);
 
   return (
     <View style={styles.container}>
@@ -258,7 +252,9 @@ function FilterCheckbox<T>({
         ref={inputRef}
         onPressRemove={onPressRemove}
         isActive={visible}
-        value={allChecked ? checkAllLabel : currentValue.map(item => item.label).join(", ")}
+        value={
+          allChecked ? t("common.filters.all") : currentValue.map(item => item.label).join(", ")
+        }
       />
 
       <Popover
@@ -487,7 +483,6 @@ export type FilterCheckboxDef<T> = {
   label: string;
   items: Item<T>[];
   width?: number;
-  checkAllLabel?: string;
 };
 
 export type FilterRadioDef<T> = {
@@ -592,12 +587,11 @@ export const FiltersStack = <T extends FiltersDefinition>({
                   onValueChange={value => onChangeFilters({ ...filters, [filterName]: value })}
                 />
               ))
-              .with({ type: "checkbox" }, ({ type, label, items, width, checkAllLabel }) => (
+              .with({ type: "checkbox" }, ({ type, label, items, width }) => (
                 <FilterCheckbox
                   label={label}
                   items={items}
                   width={width}
-                  checkAllLabel={checkAllLabel}
                   autoOpen={lastOpenedFilter === filterName}
                   value={getFilterValue(type, filters, filterName)}
                   onValueChange={value => onChangeFilters({ ...filters, [filterName]: value })}

packages/shared-business/src/locales/de.json

@@ -24,6 +24,8 @@
   "common.cancel": "Abbrechen",
   "common.close": "Schließen",
   "common.filters": "Filter",
+  "common.filters.all": "Alle",
+  "common.filters.apply": "Anwenden",
   "common.form.help.nbCharacters": "{nbCharacters} Zeichen",
   "common.form.help.nbDigits": "{nbDigits} Ziffern",
   "common.form.invalidTaxIdentificationNumber": "Diese Steueridentifikationsnummer ist ungültig",

packages/shared-business/src/locales/en.json

@@ -24,6 +24,8 @@
   "common.cancel": "Cancel",
   "common.close": "Close",
   "common.filters": "Filters",
+  "common.filters.all": "All",
+  "common.filters.apply": "Apply",
   "common.form.help.nbCharacters": "{nbCharacters} characters",
   "common.form.help.nbDigits": "{nbDigits} digits",
   "common.form.invalidTaxIdentificationNumber": "This tax identification number is invalid",

packages/shared-business/src/locales/es.json

@@ -24,6 +24,8 @@
   "common.cancel": "Cancelar",
   "common.close": "Cerrar",
   "common.filters": "Filtros",
+  "common.filters.all": "Todo",
+  "common.filters.apply": "Aplicar",
   "common.form.help.nbCharacters": "{nbCharacters} caracteres",
   "common.form.help.nbDigits": "{nbDigits} dígitos",
   "common.form.invalidTaxIdentificationNumber": "Este número de identificación fiscal no es válido",

packages/shared-business/src/locales/fi.json

@@ -24,6 +24,8 @@
   "common.cancel": "Peruuta",
   "common.close": "Sulje",
   "common.filters": "Suodattimet",
+  "common.filters.all": "Kaikki",
+  "common.filters.apply": "Käytä",
   "common.form.help.nbCharacters": "{nbCharacters} merkkiä",
   "common.form.help.nbDigits": "{nbDigits} numeroa",
   "common.form.invalidTaxIdentificationNumber": "Virheellinen verotunnistenumero",

packages/shared-business/src/locales/fr.json

@@ -24,6 +24,8 @@
   "common.cancel": "Annuler",
   "common.close": "Fermer",
   "common.filters": "Filtres",
+  "common.filters.all": "Tout",
+  "common.filters.apply": "Appliquer",
   "common.form.help.nbCharacters": "{nbCharacters} caractères",
   "common.form.help.nbDigits": "{nbDigits} chiffres",
   "common.form.invalidTaxIdentificationNumber": "Ce numéro d'identification fiscale n'est pas valide",

packages/shared-business/src/locales/it.json

@@ -24,6 +24,8 @@
   "common.cancel": "Annulla",
   "common.close": "Chiudi",
   "common.filters": "Filtri",
+  "common.filters.all": "Tutti",
+  "common.filters.apply": "Applica",
   "common.form.help.nbCharacters": "{nbCharacters} caratteri",
   "common.form.help.nbDigits": "{nbDigits} cifre",
   "common.form.invalidTaxIdentificationNumber": "Codice fiscale non valido",

packages/shared-business/src/locales/nl.json

@@ -24,6 +24,8 @@
   "common.cancel": "Annuleren",
   "common.close": "Sluiten",
   "common.filters": "Filters",
+  "common.filters.all": "Alle",
+  "common.filters.apply": "Toepassen",
   "common.form.help.nbCharacters": "{nbCharacters} tekens",
   "common.form.help.nbDigits": "{nbDigits} cijfers",
   "common.form.invalidTaxIdentificationNumber": "Dit fiscale identificatienummer is ongeldig",

packages/shared-business/src/locales/pt.json

@@ -24,6 +24,8 @@
   "common.cancel": "Cancelar",
   "common.close": "Fechar",
   "common.filters": "Filtros",
+  "common.filters.all": "Todos",
+  "common.filters.apply": "Aplicar",
   "common.form.help.nbCharacters": "{nbCharacters} caracteres",
   "common.form.help.nbDigits": "{nbDigits} dígitos",
   "common.form.invalidTaxIdentificationNumber": "Este número de identificação fiscal é inválido",