run container-anti-pattern clazy check

Author: petitlapin

src/repository.cpp

@@ -575,8 +575,9 @@ void FastImportRepository::closeFastImport()
 void FastImportRepository::reloadBranches()
 {
     bool reset_notes = false;
-    foreach (QString branch, branches.keys()) {
-        Branch &br = branches[branch];
+    for (auto it = branches.keyValueBegin(); it != branches.keyValueEnd(); ++it) {
+        const QString &branch = it->first;
+        Branch &br = it->second;
 
         if (br.marks.isEmpty() || !br.marks.last())
             continue;
@@ -1099,8 +1100,9 @@ bool FastImportRepository::Transaction::commitNote(const QByteArray &noteText, b
 
 int FastImportRepository::Transaction::commit()
 {
-    foreach (QString branchName, repository->branches.keys())
+    for (auto it = repository->branches.keyValueBegin(); it != repository->branches.keyValueEnd(); ++it)
     {
+        const QString &branchName = it->first;
         if (branchName.toUtf8().startsWith(branch + "/") || branch.startsWith((branchName + "/").toUtf8()))
         {
             qCritical() << "Branch" << branch << "conflicts with already existing branch" << branchName;

src/ruleparser.cpp

@@ -381,8 +381,8 @@ Stats::Private::Private()
 void Stats::Private::printStats() const
 {
     printf("\nRule stats\n");
-    foreach(const Rules::Match rule, m_usedRules.keys()) {
-        printf("%s was matched %i times\n", qPrintable(rule.info()), m_usedRules[rule]);
+    for (auto it = m_usedRules.keyValueBegin(); it != m_usedRules.keyValueEnd(); ++it) {
+        printf("%s was matched %i times\n", qPrintable(it->first.info()), it->second);
     }
 }
 

src/svn.cpp

@@ -567,8 +567,8 @@ int SvnRevision::commit()
     // now create the commit
     if (fetchRevProps() != EXIT_SUCCESS)
         return EXIT_FAILURE;
-    foreach (Repository *repo, repositories.values()) {
-        repo->commit();
+    for (auto it = repositories.keyValueBegin(); it != repositories.keyValueEnd(); ++it) {
+        it->second->commit();
     }
 
     foreach (Repository::Transaction *txn, transactions) {