Skip to content

fix: emit right error for a shadowed invalid rune name #15892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025

Conversation

7nik
Copy link
Contributor

@7nik 7nik commented May 11, 2025

Fixes #12888

I'm a bit unsure but looks like I fixed it in the right place.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented May 11, 2025

🦋 Changeset detected

Latest commit: 4921e36

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@15892

@Rich-Harris Rich-Harris merged commit df03af2 into sveltejs:main May 12, 2025
9 checks passed
@Rich-Harris
Copy link
Member

thank you!

@github-actions github-actions bot mentioned this pull request May 12, 2025
@7nik 7nik deleted the fix-nonexisting-subrune branch May 12, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: Misleading/missing errors on non-existent sub-runes
2 participants