-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat: add support of handleEvent object listener #15856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: c5b92b1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Is this worth adding? It seems like it's a non-zero amount of complexity and overhead for a basically useless feature, but if there's a legitimate use for handleEvent objects I suppose it could make sense to match the DOM spec |
I've been using this feature for a little while and have found it quite useful. Here's the article through which I found out about it, it's pretty interesting |
Oh, somehow I've missed that |
Closes #8196
The type of
on:event
on components is still function only, though it works with the object handler. Not sure where to fix it.In the following case, it can be considered kind of a breaking change:
and any other place where the event handler is expected to be function only.
Also, the handler object seems to never get hoisted.
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint