Skip to content

Commit 10776af

Browse files
committed
fix(no-navigation-without-resolve): Detecting asset() function as well
1 parent dc90876 commit 10776af

File tree

6 files changed

+35
-0
lines changed

6 files changed

+35
-0
lines changed

.changeset/poor-frogs-build.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'eslint-plugin-svelte': patch
3+
---
4+
5+
fix(no-navigation-without-resolve): Detecting asset() function as well

packages/eslint-plugin-svelte/src/rules/no-navigation-without-resolve.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,9 @@ function extractResolveReferences(
125125
for (const { node } of referenceTracker.iterateEsmReferences({
126126
'$app/paths': {
127127
[ReferenceTracker.ESM]: true,
128+
asset: {
129+
[ReferenceTracker.READ]: true
130+
},
128131
resolve: {
129132
[ReferenceTracker.READ]: true
130133
}
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
- message: Found a link with a url that isn't resolved.
2+
line: 5
3+
column: 9
4+
suggestions: null
5+
- message: Found a link with a url that isn't resolved.
6+
line: 6
7+
column: 9
8+
suggestions: null
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
<script>
2+
import { asset } from '$app/paths';
3+
</script>
4+
5+
<a href={asset('/foo') + '/bar'}>Click me!</a>
6+
<a href={'/foo' + asset('/bar')}>Click me!</a>
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
<script>
2+
import { asset as alias } from '$app/paths';
3+
</script>
4+
5+
<a href={alias('/foo/')}>Click me!</a>;
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
<script>
2+
import { asset } from '$app/paths';
3+
4+
const value = asset('/foo/');
5+
</script>
6+
7+
<a href={asset('/foo/')}>Click me!</a>
8+
<a href={value}>Click me!</a>

0 commit comments

Comments
 (0)