Add tool-bar icons #237
Add tool-bar icons #237
Conversation
svaante
left a comment
svaante
left a comment
There was a problem hiding this comment.
Thank you for your contribution to dape.
How is your fsf status? See Readme.
I approve of the tool-bar and the general aproch, but I am not convince on what approach to add the tool-bar is best.
dape.el
Outdated
| If valid connection, this connection will be of highest priority when | ||
| querying for connections with `dape--live-connection'.") | ||
|
|
||
| (defvar dape-tool-bar-map |
dape.el
Outdated
| (select-window window))))) | ||
|
|
||
|
|
||
| ;;; Tool bar config |
There was a problem hiding this comment.
Could we just call this sections Tool bar?
dape.el
Outdated
| comint-prompt-regexp (concat "^" (regexp-quote dape--repl-prompt)) | ||
| comint-process-echoes nil) | ||
| comint-process-echoes nil | ||
| tool-bar-map dape-tool-bar-map) |
There was a problem hiding this comment.
I think we should to the same in dape-shell-mode, dape-disassemble-mode and `dape-info-parent-mode'.
dape.el
Outdated
| (when (eq tool-bar-map dape-tool-bar-map) | ||
| (kill-local-variable 'tool-bar-map)))) | ||
| (unless (eq tool-bar-map dape-tool-bar-map) | ||
| (setq-local tool-bar-map dape-tool-bar-map)))) |
There was a problem hiding this comment.
I think it would be fine to have only dape-*-mode buffers having a tool bar but as dape does not select repl it is quite awkward to first select repl then use the buttons.
The reason I am bringing this up is that this will only prime the buffers opened when dape starts with the tool bar but not new buffers created by dape (Also we should restore local value of tool-bar-map if we overwrite it).
I see two options:
- Use repl as the selected starting window and skip this hook
- Use
find-file-hookto add the tool-bar to each new buffer (and buffers created fromdape-mime-mode-alist)
If we go with option (2.) we should probobly use modes key to figure out if a buffer should have the tool-bar.
WDYT? If we feel fine with using repl as the initial selection I think it's preferable to skip the bookkeeping needed for (2.).
If you have any other alternative ideas please share
There was a problem hiding this comment.
I find using find-file-hook (2.) somewhat complex, since it will add the tool-bar icons to any unrelated file, for example an elisp file from another project.
I think that adding the icons to only the repl buffer would be the best choice, but the problem is that cursor have to be in the repl buffer (since tool-bar icons are buffer-local)
Another idea would be to use the header-line, since it is rarely used, and unlike the tool-bar, the icons are kept even if you're not in the repl buffer
I've already done my paperwork |
|
Sorry for dropping the ball on this one @DevelopmentCool2449, I do appreciate the work. I do think that find-file is a suitable option, we can use modes from config to decide which buffers get the header. Are you interested in implementing that + the other suggestions or are you fine with me picking up where you left off? Sorry for the late response! |
|
Sorry for dropping the ball on this one @DevelopmentCool2449, I do appreciate the work. I do think that
find-file is a suitable option, we can use modes from config to decide which buffers get the header.
Are you interested in implementing that + the other suggestions or are you fine with me picking up where
you left off?
Yeah i'm interested, i will see if i can implement it (i have been busy).
…--
- E.G via GNU Emacs and Org.
|
* dape.el (dape-repl-mode): Add tool-bar icons. (dape-update-tool-bar): New function. (dape-tool-bar-map): New variable.
Copyright-paperwork-exempt: yes
Copyright-paperwork-exempt: yes
For tested version of dlv a thread id might not be given from either a thread event or a stopped event. To ensure that we don't end up in a stopped state where no thread is selected we auto select first thread from threads request.
Copyright-paperwork-exempt: yes
Suggestion from svaante#263
As suggested in discussion 262
As suggested in svaante#264
As suggested in svaante#212
As suggested in svaante#212
Thanks to daanturo for finding the unintended change
This optimization is in vscode and makes debugpy usable when emitting thousands of thread events where dape previously stalled on as many threads requests.
As suggested in svaante#267
As suggested in svaante#276
DevelopmentCool2449
force-pushed
the
scratch/tool-bar-icon
branch
from
eb0dfb2 to
524aaab
Compare
6 participants
Currently this only add the toolbar icons in the dape repl buffer and in the buffer where
dapeis called instead only the buffers that are relevant.I'm not sure how to achieve that and I don't know if there is a function in dape source that can allow me to do that.
(closes: #171)