Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insert_document only allows Path as input #91

Open
undo76 opened this issue Jan 28, 2025 · 0 comments
Open

insert_document only allows Path as input #91

undo76 opened this issue Jan 28, 2025 · 0 comments

Comments

@undo76
Copy link
Contributor

undo76 commented Jan 28, 2025

The current implementation of insert_document is quite limiting and doesn't support several use cases:

  • Reading the documents from a CSV file
  • Reading the documents from a URL

Both cases force you to save the content into a temporary file before ingestion. It is not straightforward how to allow other inputs while preserving backwards compatibility as the markdown conversion is currently done inside this method and relies on the file extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant