Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning: Command needs to be refactored, as it is written in a style that is deprecated! #18

Open
kohding opened this issue Dec 11, 2024 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@kohding
Copy link

kohding commented Dec 11, 2024

Tapped the latest version and getting the following deprecation warnings. Are you able to reproduce or is this on my end?

I've tried in zsh on M1 Max and M3 Max running Sequoia 15.1.1 (24B91).

❯ brew add duti
Warning: Calling `brew add'. This command needs to be refactored, as it is written in a style that is deprecated! Use inherits from `Homebrew::AbstractCommand' ( see https://docs.brew.sh/External-Commands ) instead.
Please report this issue to the superatomic/homebrew-bundle-extensions tap (not Homebrew/brew or Homebrew/homebrew-core), or even better, submit a PR to fix it:
  /opt/homebrew/Library/Taps/superatomic/homebrew-bundle-extensions/cmd/add.rb:7

==> Using Brewfile at '~/.config/brew/Brewfile'
==> Added Formula duti to Brewfile

❯ brew drop duti
Warning: Calling `brew drop'. This command needs to be refactored, as it is written in a style that is deprecated! Use inherits from `Homebrew::AbstractCommand' ( see https://docs.brew.sh/External-Commands ) instead.
Please report this issue to the superatomic/homebrew-bundle-extensions tap (not Homebrew/brew or Homebrew/homebrew-core), or even better, submit a PR to fix it:
  /opt/homebrew/Library/Taps/superatomic/homebrew-bundle-extensions/cmd/drop.rb:7

==> Using Brewfile at '~/.config/brew/Brewfile'
==> Dropped Formula duti from Brewfile
@superatomic
Copy link
Owner

Thank you for reporting this!

Unfortunately, since making this project, I've migrated from macOS to Fedora Linux, and no longer use Homebrew. However, I'll still take a look into fixing it (I might install Linuxbrew).

And of course, if you or anyone else is willing to write a patch yourself, I'd be happy to review a PR.

@superatomic superatomic added bug Something isn't working help wanted Extra attention is needed labels Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants