Skip to content

Conversation

@fenos
Copy link
Contributor

@fenos fenos commented Nov 12, 2025

Storage Analytics bucket

  • Fixed property from id to name

@fenos fenos requested review from a team as code owners November 12, 2025 05:41
@github-actions github-actions bot added the storage-js Related to the storage-js library. label Nov 12, 2025
@fenos fenos requested a review from Copilot November 12, 2025 05:42
Copilot finished reviewing on behalf of fenos November 12, 2025 05:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the property name in the AnalyticBucket interface from id to name, aligning the type definition with the actual API implementation. The change updates both the interface definition and the corresponding method parameters and documentation.

  • Changed AnalyticBucket.id to AnalyticBucket.name in the type definition
  • Updated deleteBucket method parameter from bucketId to bucketName with corresponding documentation
  • Removed unused Bucket import from StorageAnalyticsApi.ts

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/core/storage-js/src/lib/types.ts Updated AnalyticBucket interface property from id to name
packages/core/storage-js/src/packages/StorageAnalyticsApi.ts Updated deleteBucket parameter name, documentation, and URL construction; removed unused import
Comments suppressed due to low confidence (1)

packages/core/storage-js/src/packages/StorageAnalyticsApi.ts:112

  • The sortColumn option includes 'id' which is inconsistent with the AnalyticBucket interface that only has a name property (not id). Since AnalyticBucket doesn't have an id field, the 'id' sort column option should be removed to prevent runtime errors.
    sortColumn?: 'id' | 'name' | 'created_at' | 'updated_at'

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coveralls
Copy link

Coverage Status

coverage: 95.367% (+13.8%) from 81.58%
when pulling c12f4ce on fix/analytics-bucket-id-prop
into 1371057 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

storage-js Related to the storage-js library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants