Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade postgrest-js to 1.17 #1321

Closed
2 tasks done
ex0ns opened this issue Dec 4, 2024 · 1 comment
Closed
2 tasks done

Upgrade postgrest-js to 1.17 #1321

ex0ns opened this issue Dec 4, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@ex0ns
Copy link

ex0ns commented Dec 4, 2024

Bug report

  • I confirm this is a bug with Supabase, not with my own application.
  • I confirm I have searched the Docs, GitHub Discussions, and Discord.

Describe the bug

I have had some typing issues with my queries, most of the errors are now resolved in postgrest-js 1.17 however it seems that the upgrade to 1.17 has been reverted on main, is there a reason for that ?
Is there something we could help with in order to upgrade postgres-js to 1.17 in this repo ?

To Reproduce

Writing a query where the join key is nullable and spreading the join is not making the inner columns nullable:

  let result1: SelectQueryFromTableResult<
    'table1',
    `id, ...table2(table_id:id, table_name)`
  >

If the table2_id in table1 is number | null then both table_id and table_name should be null in the resulting type. This is not the case right now but is fixed in postgrest-1.17

Expected behavior

The generated types should be correct

System information

  • OS: osx
  • Version of supabase-js: [e.g. 6.0.2]
  • Version of Node.js: [e.g. 10.10.0]

Additional context

@ex0ns ex0ns added the bug Something isn't working label Dec 4, 2024
@ex0ns
Copy link
Author

ex0ns commented Dec 16, 2024

@ex0ns ex0ns closed this as completed Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant