Skip to content

Commit 4697e8e

Browse files
authored
chore: fix preview release to use correct target (#638)
1 parent 5f125ce commit 4697e8e

File tree

1 file changed

+13
-9
lines changed

1 file changed

+13
-9
lines changed

.github/workflows/preview-release.yml

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ on:
1515
description: 'Target branch for supabase-js tests'
1616
type: string
1717
default: 'master'
18-
18+
1919
# Push to master - only when source code changes
2020
push:
2121
branches:
@@ -25,9 +25,10 @@ on:
2525
- 'package.json'
2626
- 'package-lock.json'
2727
- 'tsconfig.json'
28-
28+
2929
# PR triggers - only when labeled
30-
pull_request:
30+
# Using pull_request_target to access secrets when PRs come from forks
31+
pull_request_target:
3132
types: [labeled, synchronize]
3233

3334
jobs:
@@ -38,7 +39,7 @@ jobs:
3839
(
3940
github.event_name == 'workflow_dispatch' ||
4041
github.event_name == 'push' ||
41-
(github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'trigger: preview'))
42+
(github.event_name == 'pull_request_target' && contains(github.event.pull_request.labels.*.name, 'trigger: preview'))
4243
)
4344
runs-on: ubuntu-latest
4445
outputs:
@@ -47,6 +48,9 @@ jobs:
4748
steps:
4849
- name: Checkout code
4950
uses: actions/checkout@v4
51+
with:
52+
# For pull_request_target, we need to explicitly checkout the PR's head
53+
ref: ${{ github.event_name == 'pull_request_target' && github.event.pull_request.head.sha || github.sha }}
5054

5155
- name: Setup Node.js
5256
uses: actions/setup-node@v4
@@ -94,7 +98,7 @@ jobs:
9498
id: generate-token
9599
uses: actions/create-github-app-token@v1
96100
with:
97-
app-id: ${{ secrets.CROSS_REPO_APP_ID }}
101+
app-id: ${{ vars.CROSS_REPO_APP_ID }}
98102
private-key: ${{ secrets.CROSS_REPO_APP_PRIVATE_KEY }}
99103
owner: supabase
100104
repositories: postgrest-js,supabase-js
@@ -153,11 +157,11 @@ jobs:
153157
body: |
154158
<!-- postgrest-js-preview-status -->
155159
🚀 **Preview release created!**
156-
160+
157161
supabase-js CI tests have been automatically triggered on feature branch to verify compatibility.
158-
162+
159163
**Preview package:** `${{ needs.preview.outputs.preview-url }}`
160-
164+
161165
Results will be posted here once testing is complete.
162-
166+
163167
edit-mode: replace

0 commit comments

Comments
 (0)