Skip to content

Test file z_15_ext_interface.out is too big and preview doesn't work #1545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
steve-chavez opened this issue Apr 14, 2025 · 1 comment
Open

Comments

@steve-chavez
Copy link
Member

Problem

The nix/tests/expected/z_15_ext_interface.out is too big and doesn't preview on github. This hurts collaboration as one has to search the raw file when reviewing its changes.

roles.out for example does work in previews:

rolname | rolcreaterole | rolcanlogin | rolsuper | rolinherit | rolcreatedb | rolreplication | rolconnlimit | rolbypassrls | rolvaliduntil
----------------------------+---------------+-------------+----------+------------+-------------+----------------+--------------+--------------+---------------
anon | f | f | f | t | f | f | -1 | f |
authenticated | f | f | f | t | f | f | -1 | f |
authenticator | f | t | f | f | f | f | -1 | f |
dashboard_user | t | f | f | t | t | t | -1 | f |
pg_checkpoint | f | f | f | t | f | f | -1 | f |

Solution

Split z_15_ext_interface.out into other files. It tests functions signatures of extensions like postgis, vault, etc. Those can go into their own files. We already have postgis.out for example.

@samrose
Copy link
Collaborator

samrose commented Apr 18, 2025

@steve-chavez it is my understanding that the .out file is generated by pg_regress

However if we split up the sql file with the same name in the nix/tests/sql directory, that should produce the results you are looking for.

In general we should not edit the .out files as they are generated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants