Skip to content

Commit 1880a4f

Browse files
felixmccuaigclaude
andcommitted
fix: update code after upstream merge and run formatting
- Format code with gofmt to pass CI checks - Update createAccountFromExternalIdentity call signature in scim_test.go to match new 5-parameter signature (added emailOptional boolean) - Update vendor directory with missing dependencies - Resolve merge conflict in configuration.go preserving both SCIM and new Experimental/Reloading configurations All linting and security checks pass (gofmt, go vet, staticcheck, gosec). Tests run successfully except for pre-existing SAML test issue unrelated to SCIM changes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent 28ef4ee commit 1880a4f

File tree

3 files changed

+402
-399
lines changed

3 files changed

+402
-399
lines changed

internal/api/middleware_test.go

Lines changed: 45 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -511,52 +511,52 @@ func (ts *MiddlewareTestSuite) TestDatabaseCleanup() {
511511
}
512512

513513
func TestRequireSCIMEnabled(t *testing.T) {
514-
api := &API{config: &conf.GlobalConfiguration{}}
515-
// disabled
516-
req := httptest.NewRequest(http.MethodGet, "/scim/v2/Users", nil)
517-
w := httptest.NewRecorder()
518-
_, err := api.requireSCIMEnabled(w, req)
519-
require.Error(t, err)
520-
521-
// enabled
522-
api.config.SCIM.Enabled = true
523-
_, err = api.requireSCIMEnabled(w, req)
524-
require.NoError(t, err)
514+
api := &API{config: &conf.GlobalConfiguration{}}
515+
// disabled
516+
req := httptest.NewRequest(http.MethodGet, "/scim/v2/Users", nil)
517+
w := httptest.NewRecorder()
518+
_, err := api.requireSCIMEnabled(w, req)
519+
require.Error(t, err)
520+
521+
// enabled
522+
api.config.SCIM.Enabled = true
523+
_, err = api.requireSCIMEnabled(w, req)
524+
require.NoError(t, err)
525525
}
526526

527527
func TestRequireSCIMAuth_BearerAndBasic(t *testing.T) {
528-
api := &API{config: &conf.GlobalConfiguration{}}
529-
api.config.SCIM.Enabled = true
530-
531-
// Bearer token success
532-
api.config.SCIM.Tokens = []string{"tok"}
533-
req := httptest.NewRequest(http.MethodGet, "/scim/v2/Users", nil)
534-
req.Header.Set("Authorization", "Bearer tok")
535-
w := httptest.NewRecorder()
536-
_, err := api.requireSCIMAuth(w, req)
537-
require.NoError(t, err)
538-
539-
// Bearer token failure
540-
req = httptest.NewRequest(http.MethodGet, "/scim/v2/Users", nil)
541-
req.Header.Set("Authorization", "Bearer wrong")
542-
w = httptest.NewRecorder()
543-
_, err = api.requireSCIMAuth(w, req)
544-
require.Error(t, err)
545-
546-
// Basic success
547-
api.config.SCIM.Tokens = nil
548-
api.config.SCIM.BasicUser = "u"
549-
api.config.SCIM.BasicPassword = "p"
550-
req = httptest.NewRequest(http.MethodGet, "/scim/v2/Users", nil)
551-
req.SetBasicAuth("u", "p")
552-
w = httptest.NewRecorder()
553-
_, err = api.requireSCIMAuth(w, req)
554-
require.NoError(t, err)
555-
556-
// Basic failure
557-
req = httptest.NewRequest(http.MethodGet, "/scim/v2/Users", nil)
558-
req.SetBasicAuth("u", "wrong")
559-
w = httptest.NewRecorder()
560-
_, err = api.requireSCIMAuth(w, req)
561-
require.Error(t, err)
528+
api := &API{config: &conf.GlobalConfiguration{}}
529+
api.config.SCIM.Enabled = true
530+
531+
// Bearer token success
532+
api.config.SCIM.Tokens = []string{"tok"}
533+
req := httptest.NewRequest(http.MethodGet, "/scim/v2/Users", nil)
534+
req.Header.Set("Authorization", "Bearer tok")
535+
w := httptest.NewRecorder()
536+
_, err := api.requireSCIMAuth(w, req)
537+
require.NoError(t, err)
538+
539+
// Bearer token failure
540+
req = httptest.NewRequest(http.MethodGet, "/scim/v2/Users", nil)
541+
req.Header.Set("Authorization", "Bearer wrong")
542+
w = httptest.NewRecorder()
543+
_, err = api.requireSCIMAuth(w, req)
544+
require.Error(t, err)
545+
546+
// Basic success
547+
api.config.SCIM.Tokens = nil
548+
api.config.SCIM.BasicUser = "u"
549+
api.config.SCIM.BasicPassword = "p"
550+
req = httptest.NewRequest(http.MethodGet, "/scim/v2/Users", nil)
551+
req.SetBasicAuth("u", "p")
552+
w = httptest.NewRecorder()
553+
_, err = api.requireSCIMAuth(w, req)
554+
require.NoError(t, err)
555+
556+
// Basic failure
557+
req = httptest.NewRequest(http.MethodGet, "/scim/v2/Users", nil)
558+
req.SetBasicAuth("u", "wrong")
559+
w = httptest.NewRecorder()
560+
_, err = api.requireSCIMAuth(w, req)
561+
require.Error(t, err)
562562
}

0 commit comments

Comments
 (0)