fix: resolve clippy warnings and improve code quality

- Remove empty line after outer attribute in pgls_diagnostics
- Replace useless format! with .to_string() in pgls_splinter
- Refactor loops to use .enumerate() and slice indexing in xtask_codegen
- Add clippy and git commit guidelines to AGENTS.md

Author: psteinroe

AGENTS.md

@@ -144,6 +144,12 @@ cargo insta review
 
 ## Development Notes
 
+### Code Quality Guidelines
+**IMPORTANT**: Always run `cargo clippy --all-targets --all-features` and fix all warnings after making code changes. Clippy warnings must be resolved before committing code to maintain code quality standards.
+
+### Git Commit and PR Guidelines
+**IMPORTANT**: NEVER add "Claude" or any AI assistant name to commit messages or pull request descriptions. Commits and PRs should appear as authored by the human developer only.
+
 ### Code Generation
 Many parser structures are generated from PostgreSQL's protobuf definitions using procedural macros in `pgls_query_macros`. Run `just gen-lint` after modifying analyzer rules or configurations.
 

crates/pgls_diagnostics/src/serde.rs

@@ -164,7 +164,6 @@ impl From<super::Location<'_>> for Location {
 #[serde(rename_all = "camelCase")]
 #[cfg_attr(feature = "schema", derive(schemars::JsonSchema))]
 #[cfg_attr(test, derive(Eq, PartialEq))]
-
 struct Advices {
     advices: Vec<Advice>,
 }

crates/pgls_splinter/src/convert.rs

@@ -60,7 +60,7 @@ fn build_remediation_url(name: &str) -> String {
         "table_bloat" => "0020_table_bloat",
         "fkey_to_auth_unique" => "0021_fkey_to_auth_unique",
         "extension_versions_outdated" => "0022_extension_versions_outdated",
-        _ => return format!("https://supabase.com/docs/guides/database/database-linter"),
+        _ => return "https://supabase.com/docs/guides/database/database-linter".to_string(),
     };
 
     format!("https://supabase.com/docs/guides/database/database-linter?lint={lint_id}")

xtask/codegen/src/generate_splinter.rs

@@ -37,19 +37,18 @@ fn extract_rules_from_sql(content: &str) -> Result<BTreeMap<String, RuleInfo>> {
     let mut rules = BTreeMap::new();
 
     let lines: Vec<&str> = content.lines().collect();
-    let mut i = 0;
 
-    while i < lines.len() {
-        let line = lines[i].trim();
+    for (i, line) in lines.iter().enumerate() {
+        let line = line.trim();
 
         // Look for pattern: 'rule_name' as "name!",
         if line.contains(" as \"name!\"") {
             if let Some(name) = extract_string_literal(line) {
                 // Look ahead for categories
                 let mut categories = None;
 
-                for j in i..std::cmp::min(i + 30, lines.len()) {
-                    let next_line = lines[j].trim();
+                for next_line in lines[i..].iter().take(30) {
+                    let next_line = next_line.trim();
 
                     // Extract categories from pattern: array['CATEGORY'] as "categories!",
                     if next_line.contains(" as \"categories!\"") {
@@ -71,8 +70,6 @@ fn extract_rules_from_sql(content: &str) -> Result<BTreeMap<String, RuleInfo>> {
                 );
             }
         }
-
-        i += 1;
     }
 
     // Add the "unknown" fallback rule