Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI step to delete stale cassettes? #5

Open
ConorMacBride opened this issue Jun 22, 2022 · 2 comments
Open

Add CI step to delete stale cassettes? #5

ConorMacBride opened this issue Jun 22, 2022 · 2 comments

Comments

@ConorMacBride
Copy link
Member

Describe the feature

If a test in this repo fails, my understanding is that the previous successful cassette will remain in this repo for use in sunpy. Is that correct?

If so, should we add a job to delete any cassettes in the repo which have a date in the HTTP header which is too old? That way tests in the sunpy repo would be forced to record a new cassette (I think?) and make the fact that the test hasn't passed recently apparent in the sunpy tests.

Proposed solution

No response

@ConorMacBride
Copy link
Member Author

Currently cassettes are not updated if only the date changes. For this to work, we could have a separate JSON/YAML file at the root of this repo which records the date the test last passed. That file could be edited by the check_new_files.py script.

@Cadair
Copy link
Member

Cadair commented Jun 23, 2022

make the fact that the test hasn't passed recently apparent in the sunpy tests.

Is that true, I was wondering the same thing here: sunpy/sunpy#6167 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants