Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArrayAnimatorWCS slices API ordering #4

Open
DanRyanIrish opened this issue Oct 8, 2020 · 2 comments
Open

ArrayAnimatorWCS slices API ordering #4

DanRyanIrish opened this issue Oct 8, 2020 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@DanRyanIrish
Copy link
Member

Description

The ordering of the slices list input to ArrayAnimatorWCS is in WCS order. However, this is not stated in the docstring. Is this a bug? Should slices in fact be Numpy order to be consistent with the data array?

Expected vs Actual behavior

Steps to Reproduce

Code goes here

System Details

  • SunPy Version:
  • Astropy Version:
  • Python Version:
  • OS information:
@Cadair
Copy link
Member

Cadair commented Oct 14, 2020

It follows WCSAxes which is wcs order, the current behaviour should be documented.

@dstansby

This comment was marked as outdated.

Sign in to view
@Cadair Cadair transferred this issue from sunpy/sunpy Oct 29, 2021
@Cadair Cadair added documentation help wanted Extra attention is needed labels Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Cadair @dstansby @DanRyanIrish